Differential D50152

LinuxKPI: add is_unicast_ether_addr()
ClosedPublic
Actions

Authored by bz on Sun, May 4, 10:00 PM.

Tags

None

Referenced Files

	F117593944: D50152.diff
	Tue, May 20, 2:13 PM

	Unknown Object (File)
	Sat, May 17, 7:57 AM

	Unknown Object (File)
	Tue, May 13, 7:06 AM

	Unknown Object (File)
	Mon, May 12, 3:20 AM

	Unknown Object (File)
	Thu, May 8, 10:19 PM

	Unknown Object (File)
	Tue, May 6, 9:58 AM

	Unknown Object (File)
	Tue, May 6, 5:05 AM

	Unknown Object (File)
	Tue, May 6, 4:47 AM

View All 11 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rG707cfc54f8f3: LinuxKPI: add is_unicast_ether_addr()
rGa4618caa43c1: LinuxKPI: add is_unicast_ether_addr()

Summary

Needed by mediatek/mt76 wireless driver.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz created this revision.Sun, May 4, 10:00 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptSun, May 4, 10:00 PM

bz requested review of this revision.Sun, May 4, 10:00 PM

Harbormaster completed remote builds in B63876: Diff 154807.Sun, May 4, 10:01 PM

emaste accepted this revision.Sun, May 4, 10:09 PM

emaste added inline comments.

sys/compat/linuxkpi/common/include/linux/etherdevice.h
69	This seems like an obtuse way for someone to have written this expression

This revision is now accepted and ready to land.Sun, May 4, 10:09 PM

bz marked an inline comment as done.Sun, May 4, 10:20 PM

bz added inline comments.

sys/compat/linuxkpi/common/include/linux/etherdevice.h
69	Don't ask me where this originally came from. The last change to that line is a whitespace cleaning up said file massively as apparently suggested by you.

emaste added inline comments.Sun, May 4, 10:26 PM

sys/compat/linuxkpi/common/include/linux/etherdevice.h
69	Looks like it came from the first rev - 8d59ecb214f7e078e57d35b865f33efc5d7cdf4d. I was going to suggest making the new function consistent with the existing "style" but it seems so odd to write it that way. Someone can switch it around later on if so inclined.

While here adjust the way is_multicast_ether_addr() is implemented
to not look weird. [1]

Suggested by: @emaste [1]

This revision now requires review to proceed.Sun, May 4, 10:36 PM

Harbormaster completed remote builds in B63883: Diff 154817.Sun, May 4, 10:36 PM

bz marked an inline comment as done.Sun, May 4, 10:36 PM

emaste accepted this revision.Sun, May 4, 10:52 PM

This revision is now accepted and ready to land.Sun, May 4, 10:52 PM

Closed by commit rGa4618caa43c1: LinuxKPI: add is_unicast_ether_addr() (authored by bz). · Explain WhyMon, May 5, 10:47 AM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGa4618caa43c1: LinuxKPI: add is_unicast_ether_addr().

bz added a commit: rG707cfc54f8f3: LinuxKPI: add is_unicast_ether_addr().Wed, May 7, 11:51 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

8 lines

Diff 154839

sys/compat/linuxkpi/common/include/linux/etherdevice.h

Loading...