Page MenuHomeFreeBSD

Don't create a dedicated session for each AIO kernel process.
ClosedPublic

Authored by jhb on Jan 18 2016, 10:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 26 2023, 11:44 AM
Unknown Object (File)
Dec 21 2023, 9:51 PM
Unknown Object (File)
Dec 20 2023, 1:09 AM
Unknown Object (File)
Dec 11 2023, 10:12 PM
Unknown Object (File)
Dec 9 2023, 7:42 PM
Unknown Object (File)
Dec 9 2023, 8:14 AM
Unknown Object (File)
Nov 23 2023, 3:39 PM
Unknown Object (File)
Nov 19 2023, 3:42 AM
Subscribers

Details

Summary

Don't create a dedicated session for each AIO kernel process.

This code dates back to the initial AIO support and the commit log does
not explain why it is needed. However, I cannot find anything in the
AIO code or the various file methods (fo_read/fo_write) that would change
behavior due to using a private session instead of proc0's session.

Test Plan
  • Ran all of the aio tests in the test suite. No regressions.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb retitled this revision from to Don't create a dedicated session for each AIO kernel process..
jhb updated this object.
jhb edited the test plan for this revision. (Show Details)
jhb added a reviewer: kib.
kib edited edge metadata.

I think what could be different with the call is the handling of the SIGTTYIN/SIGTTYOUT conditions for terminal i/o. But I believe that aio daemons groups cannot be in background set for any terminal, regardless of whether they are in proc0 or its own group.

This revision is now accepted and ready to land.Jan 19 2016, 2:54 AM
This revision was automatically updated to reflect the committed changes.