Page MenuHomeFreeBSD

fts: Move private flags away from public ones.
ClosedPublic

Authored by des on Apr 8 2025, 3:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 3, 4:40 PM
Unknown Object (File)
Fri, Oct 3, 4:36 PM
Unknown Object (File)
Fri, Oct 3, 8:12 AM
Unknown Object (File)
Thu, Oct 2, 4:27 PM
Unknown Object (File)
Sun, Sep 28, 1:17 AM
Unknown Object (File)
Tue, Sep 23, 12:09 AM
Unknown Object (File)
Sep 17 2025, 10:06 AM
Unknown Object (File)
Sep 16 2025, 4:12 PM
Subscribers

Details

Summary

Renumber the private flags so there is a sizeable gap between them and
the public flags, making it easier to add public flags in the future.
These private flags are only ever set or read by FTS itself, so there
is no compatibility issue.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Apr 8 2025, 3:26 PM
markj added inline comments.
include/fts.h
49–64

I see a reference to FTS_NAMEONLY in ls.c, so this seems to be a de facto public flag and thus shouldn't be changed?

include/fts.h
49–64

Ah, you're right, it's a special case because it can't be passed to fts_open() but it gets set temporarily if passed to fts_children(). I'll have to revise the patch.

This is probably ok. I couldn't find any examples of third-party code actually using this flag.

This revision is now accepted and ready to land.Apr 9 2025, 4:21 PM
des marked an inline comment as done.Apr 9 2025, 4:59 PM
This revision was automatically updated to reflect the committed changes.