contrib/netbsd-tests/usr.bin/grep/t_grep.sh
Fix grep_test:recurse when /tmp is either zfs or tmpfs. The test
was relying on an implicit ordering of directory recursion which
happens to be true when using UFS. grep's specification requires no
such ordering. The solution is to ignore the order of grep's
results.
Details
Details
- Reviewers
ngie - Commits
- rS294923: Fix grep_test:recurse with ZFS and TMPFS tmpdirs
mount -t tmpfs tmpfs /mnt
TMPDIR=/mnt kyua test grep_test:recurse
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| contrib/netbsd-tests/usr.bin/grep/t_grep.sh | ||
|---|---|---|
| 73 ↗ | (On Diff #12264) | Please do something like this so I can track this needing to be submitted back to NetBSD: # Begin FreeBSD if true; then atf_check -o file:"$(atf_get_srcdir)/d_recurse.out" -x "grep -r haddock recurse | sort" else # End FreeBSD atf_check -o file:"$(atf_get_srcdir)/d_recurse.out" grep -r haddock recurse # Begin FreeBSD fi # End FreeBSD |
Comment Actions
Add FreeBSD note as requested by ngie. I'm not exactly sure what
indentation style ngie wanted. I'm treating the "(Begin|End) FreeBSD"
statements like C #ifdefs, and not indenting their bodies.
| contrib/netbsd-tests/usr.bin/grep/t_grep.sh | ||
|---|---|---|
| 78–81 ↗ | (On Diff #12316) | Please reply to this comment. |
Comment Actions
Ugh. I accidentally missed that you followed through with the feedback (please mark Done next time).