Page MenuHomeFreeBSD
Differential D49213

pfctl: Fix printing af-to "to" pool
ClosedPublic
Actions

Authored by vegeta_tuxpowered.net on Mar 3 2025, 11:38 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 1, 4:51 AM
Unknown Object (File)
Sat, Mar 21, 11:27 PM
Unknown Object (File)
Sat, Mar 21, 5:07 PM
Unknown Object (File)
Thu, Mar 19, 5:17 PM
Unknown Object (File)
Wed, Mar 18, 1:32 PM
Unknown Object (File)
Wed, Mar 18, 1:23 PM
Unknown Object (File)
Fri, Mar 13, 4:28 AM
Unknown Object (File)
Wed, Mar 11, 1:22 AM
View All 74 Files
Subscribers
imp

Details

Reviewers
kp
Commits
rG2624ba37e633: pfctl: Fix printing af-to "to" pool
Summary

We can't depend on pool->cur, that is used only inside of kernel for
iterating over members of the pool, it is not filled in during loading
of ruleset.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

vegeta_tuxpowered.net created this revision.Mar 3 2025, 11:38 AM
Herald added a subscriber: imp. · View Herald TranscriptMar 3 2025, 11:38 AM
vegeta_tuxpowered.net requested review of this revision.Mar 3 2025, 11:38 AM
kp accepted this revision.EditedMar 3 2025, 2:39 PM

Do you have an example of how this can go wrong?

(Edit: and approved to commit)

This revision is now accepted and ready to land.Mar 3 2025, 2:39 PM
Closed by commit rG2624ba37e633: pfctl: Fix printing af-to "to" pool (authored by vegeta_tuxpowered.net). · Explain WhyMar 4 2025, 12:16 PM
This revision was automatically updated to reflect the committed changes.
vegeta_tuxpowered.net added a commit: rG2624ba37e633: pfctl: Fix printing af-to "to" pool.

Revision Contents
Changeset List

PathSize
sbin/
pfctl/
2 lines

Diff 151837

View Options

sbin/pfctl/pfctl_parser.c

Loading...