pfctl: Fix printing af-to "to" pool
ClosedPublic
Actions

Authored by vegeta_tuxpowered.net on Mar 3 2025, 11:38 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jan 21, 10:26 PM

	Unknown Object (File)
	Sat, Jan 10, 1:17 PM

	Unknown Object (File)
	Dec 14 2025, 2:49 AM

	Unknown Object (File)
	Dec 8 2025, 3:25 AM

	Unknown Object (File)
	Dec 2 2025, 10:17 AM

	Unknown Object (File)
	Dec 1 2025, 12:52 AM

	Unknown Object (File)
	Nov 27 2025, 8:07 AM

	Unknown Object (File)
	Nov 24 2025, 10:16 PM

View All 62 Files

Subscribers

imp

Details

Reviewers

Commits

rG2624ba37e633: pfctl: Fix printing af-to "to" pool

Summary

We can't depend on pool->cur, that is used only inside of kernel for
iterating over members of the pool, it is not filled in during loading
of ruleset.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

vegeta_tuxpowered.net created this revision.Mar 3 2025, 11:38 AM

Herald added a subscriber: imp. · View Herald TranscriptMar 3 2025, 11:38 AM

vegeta_tuxpowered.net requested review of this revision.Mar 3 2025, 11:38 AM

Do you have an example of how this can go wrong?

(Edit: and approved to commit)

This revision is now accepted and ready to land.Mar 3 2025, 2:39 PM

Closed by commit rG2624ba37e633: pfctl: Fix printing af-to "to" pool (authored by vegeta_tuxpowered.net). · Explain WhyMar 4 2025, 12:16 PM

This revision was automatically updated to reflect the committed changes.

vegeta_tuxpowered.net added a commit: rG2624ba37e633: pfctl: Fix printing af-to "to" pool.

Revision Contents
Changeset List

Path

Size

sbin/

pfctl/

pfctl_parser.c

2 lines

Diff 151837

View Options

pfctl: Fix printing af-to "to" poolClosedPublicActions