Page MenuHomeFreeBSD

vm_object: don't reset new iterator
ClosedPublic

Authored by dougm on Mar 3 2025, 6:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 2:22 PM
Unknown Object (File)
Mon, Oct 13, 12:26 PM
Unknown Object (File)
Sat, Oct 11, 6:40 PM
Unknown Object (File)
Thu, Oct 9, 2:58 AM
Unknown Object (File)
Mon, Oct 6, 11:11 PM
Unknown Object (File)
Wed, Sep 24, 1:34 AM
Unknown Object (File)
Wed, Sep 24, 1:22 AM
Unknown Object (File)
Tue, Sep 23, 4:48 PM
Subscribers

Details

Summary

Don't call pctrie_iter_reset on a just-initialized iterator. Let the code jumping back up do the resetting.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dougm requested review of this revision.Mar 3 2025, 6:47 AM
dougm created this revision.

Is there a way to assert that the iterator is in initial state (I suppose it is trivial to add)? I suggest to assert that in places where the reset was done before the change, so that new 'gotos again' do not miss the reset.

After some goto targets, assert that the iterators have been reset.

This revision is now accepted and ready to land.Mar 4 2025, 4:16 AM
This revision was automatically updated to reflect the committed changes.