Page MenuHomeFreeBSD

devel/linux_libusb: Use CSTD of gnu11 for the c7 flavor
ClosedPublic

Authored by jhb on Feb 12 2025, 10:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 4:51 PM
Unknown Object (File)
Sun, Oct 12, 12:21 PM
Unknown Object (File)
Sun, Oct 12, 10:28 AM
Unknown Object (File)
Sun, Oct 12, 8:24 AM
Unknown Object (File)
Sun, Oct 12, 6:57 AM
Unknown Object (File)
Thu, Oct 2, 3:26 PM
Unknown Object (File)
Thu, Oct 2, 2:57 AM
Unknown Object (File)
Wed, Oct 1, 2:16 PM
Subscribers

Details

Summary

This fixes the build on 15.0 where the default CSTD of gnu17 is not
supported by the old version of gcc used for CentOS 7.

PR: 284039

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Feb 12 2025, 10:37 PM
jhb created this revision.

I'm obscured how this works. What exactly reacts to the CSTD env var? I see nothing using it in Ports framework, nor in devel/linux_libusb sources.

This is building FreeBSD source code from the base system but cross-compiled for Linux. It is using bsd.lib.mk from base and that is what uses CSTD. I recently bumped CSTD from gnu99 to gnu17 in main which broke this port since the version of GCC that ships with CentOS 7 is too old to understand C17.

Ah, now I see, thanks for explanations. The patch is good Ports-wise.

This revision is now accepted and ready to land.Feb 27 2025, 6:28 AM