devel/linux_libusb: Use CSTD of gnu11 for the c7 flavor
ClosedPublic
Actions

Authored by jhb on Feb 12 2025, 10:37 PM.

Details

Reviewers

imp
arrowd

Commits

R11:e7f4ef88c35d: devel/linux_libusb: Use CSTD of gnu11 for the c7 flavor

Summary

This fixes the build on 15.0 where the default CSTD of gnu17 is not
supported by the old version of gcc used for CentOS 7.

PR: 284039

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb requested review of this revision.Feb 12 2025, 10:37 PM

jhb created this revision.

Harbormaster completed remote builds in B62404: Diff 150927.Feb 12 2025, 10:37 PM

I'm obscured how this works. What exactly reacts to the CSTD env var? I see nothing using it in Ports framework, nor in devel/linux_libusb sources.

This is building FreeBSD source code from the base system but cross-compiled for Linux. It is using bsd.lib.mk from base and that is what uses CSTD. I recently bumped CSTD from gnu99 to gnu17 in main which broke this port since the version of GCC that ships with CentOS 7 is too old to understand C17.

Ah, now I see, thanks for explanations. The patch is good Ports-wise.

This revision is now accepted and ready to land.Feb 27 2025, 6:28 AM

Closed by commit R11:e7f4ef88c35d: devel/linux_libusb: Use CSTD of gnu11 for the c7 flavor (authored by jhb). · Explain WhyFeb 27 2025, 3:49 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: R11:e7f4ef88c35d: devel/linux_libusb: Use CSTD of gnu11 for the c7 flavor.