[PATCH] net/akhq: Clean up port

[kiwi]

Summary

net/akhq: Clean up port

In Makefile:
- Better COMMENT
- Use ${ETCDIR} when applicable
- Update PLIST_FILES
- Removed post-install part

In service file:
- Use %WWWOWN%%

In sample configuration file, bind to 127.0.0.1 instead of 0.0.0.0

Sponsored by:   Klara, Inc.
Approved by:    0mp (mentor)

[kiwi]

Fix PLIST_SUB add SUB_LIST as well

[0mp]

Approved!

[diizzy]

This is not how sample (config) should be handled?
https://docs.freebsd.org/en/books/porters-handbook/book/#plist-config

[diizzy]

Additionally why was this committed without maintainer consent (or maintainer timeout)?

[kiwi]

In D48886#1115064, @diizzy wrote:

Additionally why was this committed without maintainer consent (or maintainer timeout)?

Maintainer asked Klara to push this port (see previous commits), my mentor, 0mp, asked me to fix some things in the port that maintainer didn't do.

[diizzy]

In that case it should be referenced in commit message and from what I can tell there's no request anywhere? There's only one commit prior to this one regarding this port so I'm not sure what you're referring to.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274149

Anyway, having a quick look...

• Port is still handling the sample file incorrectly
• NO_EXTRACT is oddly placed and I would argue that CONFIG_FILES also is
• DIST and PORTVERSION are mixed for no apparent reason
• Preferably also use PREFIX rather than LOCALBASE in .in file

grep -lir LOCALBASE --include "*.in" /usr/ports/ |wc -l
     403
grep -lir PREFIX --include "*.in" /usr/ports/ | wc -l
    2745

[kiwi]

In D48886#1117828, @diizzy wrote:

In that case it should be referenced in commit message and from what I can tell there's no request anywhere? There's only one commit prior to this one regarding this port so I'm not sure what you're referring to.
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274149

Well we (Klara) have a private working relationship with the maintainer of this port.

Anyway, having a quick look...

• Port is still handling the sample file incorrectly
• NO_EXTRACT is oddly placed and I would argue that CONFIG_FILES also is
• DIST and PORTVERSION are mixed for no apparent reason
• Preferably also use PREFIX rather than LOCALBASE in .in file

grep -lir LOCALBASE --include "*.in" /usr/ports/ |wc -l
     403
grep -lir PREFIX --include "*.in" /usr/ports/ | wc -l
    2745

Thanks for this, will work on this and fills a new review to reflect the corrected changes.