unifdef: Fix collision check when adding symbols.
ClosedPublic
Actions

Authored by des on Jan 30 2025, 6:44 PM.

Details

Reviewers

Group Reviewers

Commits

rG1aaec1978a29: unifdef: Fix collision check when adding symbols.
rG931b0990297e: unifdef: Fix collision check when adding symbols.
rG67cead936d0a: unifdef: Fix collision check when adding symbols.
rGc63af363c245: unifdef: Fix collision check when adding symbols.

Summary

findsym() is intended for use while parsing input, so it should not be
called from addsym2() or indirectsym(), which are called before any
input is processed.

MFC after: 1 week
Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

des created this revision.Jan 30 2025, 6:44 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 30 2025, 6:44 PM

des requested review of this revision.Jan 30 2025, 6:44 PM

Harbormaster completed remote builds in B62163: Diff 150222.Jan 30 2025, 6:44 PM

test name

Harbormaster completed remote builds in B62164: Diff 150223.Jan 30 2025, 6:46 PM

kevans accepted this revision.Jan 30 2025, 9:07 PM

This revision is now accepted and ready to land.Jan 30 2025, 9:07 PM

Closed by commit rGc63af363c245: unifdef: Fix collision check when adding symbols. (authored by des). · Explain WhyJan 30 2025, 9:11 PM

This revision was automatically updated to reflect the committed changes.

des added a commit: rGc63af363c245: unifdef: Fix collision check when adding symbols..

des added a commit: rG67cead936d0a: unifdef: Fix collision check when adding symbols..Feb 13 2025, 12:38 AM

des added a commit: rG931b0990297e: unifdef: Fix collision check when adding symbols..

des added a commit: rG1aaec1978a29: unifdef: Fix collision check when adding symbols..Feb 13 2025, 3:12 PM

Revision Contents
Changeset List

Path

Size

contrib/

unifdef/

unifdef.c

11 lines

usr.bin/

unifdef/

tests/

unifdef_test.sh

10 lines

Diff 150226

View Options

contrib/unifdef/unifdef.c