pvscsi: Explicitly mask out CTS_SAS_VALID_SPEED bit
ClosedPublic
Actions

Authored by zlei on Jan 13 2025, 9:02 AM.

Details

Reviewers

Commits

rG25695358d03b: pvscsi: Explicitly mask out CTS_SAS_VALID_SPEED bit
rG5094faf5dfa8: pvscsi: Explicitly mask out CTS_SAS_VALID_SPEED bit
rG7befd68335a0: pvscsi: Explicitly mask out CTS_SAS_VALID_SPEED bit

Summary

This driver report connection speed over sas port speed. On stable/13 branch the stack-allocated CCB is not cleared thus on boot the the cam layer may report wrong speed. -current and stable/14 are not affected, but I want -current and stable/14 to have this in to reduce drift between branches.

da0: <VMware Virtual disk 2.0> Fixed Direct Access SPC-4 SCSI device
da0: 4294967.295MB/s transfers

MFC after: 3 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

zlei requested review of this revision.Jan 13 2025, 9:02 AM

zlei created this revision.

zlei edited the summary of this revision. (Show Details)Jan 13 2025, 9:15 AM

emaste added a subscriber: emaste.Jan 13 2025, 2:59 PM

imp accepted this revision.Jan 15 2025, 2:46 AM

This revision is now accepted and ready to land.Jan 15 2025, 2:46 AM

Closed by commit rG7befd68335a0: pvscsi: Explicitly mask out CTS_SAS_VALID_SPEED bit (authored by zlei). · Explain WhyJan 15 2025, 4:34 AM

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG7befd68335a0: pvscsi: Explicitly mask out CTS_SAS_VALID_SPEED bit.

zlei added a commit: rG5094faf5dfa8: pvscsi: Explicitly mask out CTS_SAS_VALID_SPEED bit.Jan 20 2025, 10:16 AM

zlei added a commit: rG25695358d03b: pvscsi: Explicitly mask out CTS_SAS_VALID_SPEED bit.Jan 20 2025, 12:42 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

vmware/

pvscsi/

pvscsi.c

4 lines

Diff 149278

View Options

sys/dev/vmware/pvscsi/pvscsi.c

pvscsi: Explicitly mask out CTS_SAS_VALID_SPEED bitClosedPublicActions