Page MenuHomeFreeBSD

Fix lib/libc/nss/getgr_test with large numbers of groups
ClosedPublic

Authored by asomers on Dec 31 2024, 9:01 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 5, 6:31 AM
Unknown Object (File)
Tue, Aug 4, 6:44 AM
Unknown Object (File)
Sun, Aug 2, 11:04 AM
Unknown Object (File)
Mon, Jul 27, 1:32 PM
Unknown Object (File)
Tue, Jul 21, 4:51 AM
Unknown Object (File)
Mon, Jul 20, 9:40 PM
Unknown Object (File)
Mon, Jul 20, 5:16 PM
Unknown Object (File)
Sun, Jul 12, 11:47 AM
Subscribers

Details

Summary

These tests create a linked list with one entry for every group on the
running system. On a system with about 30,000 groups, the test took 69
seconds to run, and crashed Kyua with the below error:

kyua: E: string or blob too big (sqlite op: sqlite3_bind_blob) (sqlite db: /root/.kyua/store/results.usr_tests.20241231-203317-570235.db).

Fix the test by limiting it to operating on the first 1024 groups.
Apply the same change to getpw_test and getserv_test too, which are
vulnerable to the same problem.

MFC after: 2 weeks
Sponsored by: ConnectWise

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable