ping: adjust error messages and comments for -gGh flags
ClosedPublic
Actions

Authored by maxim on Dec 28 2024, 9:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 20, 9:16 AM

	Unknown Object (File)
	Sun, May 17, 6:57 PM

	Unknown Object (File)
	Fri, May 15, 10:39 PM

	Unknown Object (File)
	Fri, May 15, 10:38 PM

	Unknown Object (File)
	Fri, May 15, 10:38 PM

	Unknown Object (File)
	Sun, May 3, 9:58 AM

	Unknown Object (File)
	Apr 25 2026, 8:56 PM

	Unknown Object (File)
	Apr 23 2026, 11:05 AM

View All 81 Files

Subscribers

imp

Details

Reviewers

glebius

Commits

rG8408510c7769: ping: adjust error messages and comments for -gGh flags

Summary

The -gGh flags are used for sweep ping to specify minimal,
maximum and increment sizes for the ICMP payload, not the packet
size. Adjust the error messages and comments accordingly.

Test Plan

no real functional changes here, just error messages
correction

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

maxim created this revision.Dec 28 2024, 9:26 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 28 2024, 9:26 PM

maxim requested review of this revision.Dec 28 2024, 9:26 PM

Harbormaster completed remote builds in B61372: Diff 148486.Dec 28 2024, 9:26 PM

maxim added a reviewer: glebius.Dec 28 2024, 10:09 PM

glebius accepted this revision.Dec 28 2024, 11:24 PM

This revision is now accepted and ready to land.Dec 28 2024, 11:24 PM

Closed by commit rG8408510c7769: ping: adjust error messages and comments for -gGh flags (authored by maxim). · Explain WhyDec 28 2024, 11:33 PM

This revision was automatically updated to reflect the committed changes.

maxim added a commit: rG8408510c7769: ping: adjust error messages and comments for -gGh flags.

Revision Contents
Changeset List

Path

Size

sbin/

ping/

ping.c

18 lines

Diff 148496

View Options

ping: adjust error messages and comments for -gGh flagsClosedPublicActions