*/*: Use my @FreeBSD.org email as MAINTAINER Approved by: 0mp (mentor)
Details
Details
- Reviewers
0mp - Commits
- R11:6d9bec7d67cc: */*: Use my @FreeBSD.org email as MAINTAINER
Diff Detail
Diff Detail
- Repository
- R11 FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
The change looks pretty good.
You may consider using FreeBSD.org instead of freebsd.org. That's the convention:
mp@dev /freebsd/ports $ rg 'MAINTAINER=.*freebsd.org' | wc -l 42 mp@dev /freebsd/ports $ rg 'MAINTAINER=.*FreeBSD.org' | wc -l 54712
Comment Actions
Great!
Could you add the whole, final commit message to the description here on Phab? I'd like to make sure you don't miss anything (please include Approved by: 0mp (mentor) but do not push the change upstream yet).
Comment Actions
*/*: Use my @FreeBSD.org email as MAINTAINER Approved by: 0mp (mentor)
looks good to me. It'd only need the Differntial Revision line and it's good to go.