Differential D47947

Kill ignore regshft flag
ClosedPublic
Actions

Authored by imp on Dec 6 2024, 6:02 PM.

Tags

None

Referenced Files

	F110526233: D47947.id149273.diff
	Wed, Feb 19, 4:28 PM

	Unknown Object (File)
	Wed, Feb 12, 5:18 PM

	Unknown Object (File)
	Wed, Feb 12, 12:41 AM

	Unknown Object (File)
	Sat, Feb 1, 9:37 AM

	Unknown Object (File)
	Wed, Jan 29, 5:45 PM

	Unknown Object (File)
	Jan 20 2025, 12:35 AM

	Unknown Object (File)
	Jan 19 2025, 2:49 PM

	Unknown Object (File)
	Jan 19 2025, 2:24 PM

View All 18 Files

Subscribers

Details

Reviewers

Commits

rG5db3699be68f: Kill ignore regshft flag

Summary

This flag was introduced to ignore bad firmware values. These were
present in older versions of EDK-II that many devices (both Ampere and
Amazon) used. QEMU also used this value, but fixed it. But since it's
tied to the firmware bug not the device name ID it doesn't make sense to
have it flagged there.

Sponsored by: Netflix

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Dec 6 2024, 6:02 PM

imp created this revision.

Harbormaster completed remote builds in B60986: Diff 147613.Dec 6 2024, 6:02 PM

imp added a parent revision: D47946: uart: Ingore pl011 historic mistakes.Dec 6 2024, 6:03 PM

emaste accepted this revision.Dec 6 2024, 7:05 PM

This revision is now accepted and ready to land.Dec 6 2024, 7:05 PM

Needs a code tweak to compile.

sys/dev/uart/uart_dev_pl011.c
381	s/uc_regiowidth/uc_riowidth/

rebase

This revision now requires review to proceed.Jan 14 2025, 9:47 PM

Harbormaster completed remote builds in B61726: Diff 149270.Jan 14 2025, 9:47 PM

emaste accepted this revision.Jan 14 2025, 9:53 PM

This revision is now accepted and ready to land.Jan 14 2025, 9:53 PM

Closed by commit rG5db3699be68f: Kill ignore regshft flag (authored by imp). · Explain WhyJan 15 2025, 2:26 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG5db3699be68f: Kill ignore regshft flag.

Revision Contents
Changeset List

Path

Size

sys/

dev/

uart/

1 line

uart_cpu_acpi.c

12 lines

uart_dev_pl011.c

6 lines

Diff 149273

sys/dev/uart/uart_bus.h

Loading...

sys/dev/uart/uart_cpu_acpi.c

Loading...

sys/dev/uart/uart_dev_pl011.c

Loading...