Fix building with GCC since PAGE_MASK is signed on i386.
ClosedPublic
Actions

Authored by jhb on Jan 4 2016, 12:37 AM.

Tags

None

Referenced Files

	F170653590: D4772.id11894.diff
	Sat, Sep 5, 8:14 PM

	Unknown Object (File)
	Tue, Aug 25, 7:30 AM

	Unknown Object (File)
	Sat, Aug 22, 8:01 PM

	Unknown Object (File)
	Sat, Aug 22, 8:01 PM

	Unknown Object (File)
	Sat, Aug 22, 8:00 PM

	Unknown Object (File)
	Tue, Aug 11, 5:38 AM

	Unknown Object (File)
	Jul 3 2026, 3:25 AM

	Unknown Object (File)
	Jul 2 2026, 9:17 PM

View All Files

Subscribers

imp

Details

Reviewers

ngie

Commits

rS293979: Fix building with GCC since PAGE_MASK is signed on i386.

Summary

Fix building with GCC since PAGE_MASK is signed on i386.

Test Plan

make buildworld of HEAD in a 9.x i386 VM
make tinderbox on HEAD (to ensure no regressions)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 11894.Jan 4 2016, 12:37 AM

jhb retitled this revision from to Fix building with GCC since PAGE_MASK is signed on i386..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added a reviewer: ngie.

Herald added a subscriber: imp. · View Herald TranscriptJan 4 2016, 12:37 AM

This worked for i386 on universe9a.freebsd.org -- thanks!

This revision is now accepted and ready to land.Jan 14 2016, 8:33 AM

Closed by commit rS293979: Fix building with GCC since PAGE_MASK is signed on i386. (authored by jhb). · Explain WhyJan 14 2016, 3:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lib/

libkvm/

kvm_i386.h

2 lines

Diff 12317

View Options

head/lib/libkvm/kvm_i386.h

Fix building with GCC since PAGE_MASK is signed on i386.ClosedPublicActions