Page MenuHomeFreeBSD

ntpd: Fix crash when bringing up net interface fails
AcceptedPublic

Authored by rcm on Nov 4 2024, 4:09 PM.
Tags
None
Referenced Files
F131665898: D47436.diff
Fri, Oct 10, 4:16 AM
Unknown Object (File)
Thu, Oct 2, 10:07 AM
Unknown Object (File)
Wed, Oct 1, 5:54 PM
Unknown Object (File)
Tue, Sep 30, 8:34 AM
Unknown Object (File)
Sat, Sep 27, 12:24 AM
Unknown Object (File)
Wed, Sep 24, 2:58 AM
Unknown Object (File)
Thu, Sep 18, 9:03 PM
Unknown Object (File)
Sat, Sep 13, 2:06 PM
Subscribers

Details

Reviewers
cy
Summary

The latest vendor import of ntp-4.2.8p18 includes a bug that can cause a
segfault in an error message related to failing to bring up an endpoint
during interface setup. This occurs due to unhandled cases in the
error-handling path that reference uninitialized or freed fields in endpt,
leading to a crash under certain conditions.

PR: 281202
Obtained from: https://bugs.ntp.org/show_bug.cgi?id=3928
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

rcm requested review of this revision.Nov 4 2024, 4:09 PM

lgtm

Can you also submit a revision for the ntp port, please?

This revision is now accepted and ready to land.Nov 4 2024, 6:27 PM