Previously these ivars were leaked.
Details
Details
- Reviewers
imp - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) - Commits
- rG8973edf29b3d: superio: Use a bus_child_deleted method to free ivars for children
rGbfe10b7712a5: superio: Use a bus_child_deleted method to free ivars for children
rG2520675d3f0e: superio: Use a bus_child_deleted method to free ivars for children
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
(more a comment in passing than a request for change)
sys/dev/superio/superio.c | ||
---|---|---|
780 | After seeing a bunch of these, I kinda wonder if there's some way we can refactor this into newbus. |
sys/dev/superio/superio.c | ||
---|---|---|
780 | Maybe the actual free could be pulled up into new-bus similar how softc allocation is managed, but the resource_list bit means you'd end up with a child_deleted method anyway, so I'm not sure it buys much. There are a couple of related things it might be nice to fix to be more consistent in this area:
|