Quisece one printf warnings
ClosedPublic
Actions

Authored by sbruno on Jul 23 2014, 9:37 PM.

Details

Reviewers

delphij
mahrens

Summary

fix typos to quiesce to compile warnings

Repository

rS FreeBSD src repository - subversion

Lint

No Lint Coverage

Unit

No Test Coverage

sbruno retitled this revision from to Quisece two printf warnings.

sbruno updated this object.

sbruno edited the test plan for this revision. (Show Details)

sbruno added a reviewer: delphij.

Looks good to me, maybe upstream too?

This revision is now accepted and ready to land.Jul 23 2014, 9:39 PM

I've sent this to Matt Ahrens in email as well. He doesn't have a phabric account yet.

Update correct position in the printf string. Apparently, my eyes are off.

mahrens added inline comments.

cddl/contrib/opensolaris/lib/libzpool/common/kernel.c
690	looks good; bug does not exist upstream.
cddl/contrib/opensolaris/lib/libzpool/common/util.c
108	This change looks incorrect to me. the format and corresponding arguments are: "%s", indent, "", "%s", prefix, "%s", indent + strlen(prefix) - 25 - (vs->vs_space ? 0 : 12), desc, ... note that "prefix" is a string not an integer, so the existing code is correct.