Page MenuHomeFreeBSD

igc: Fix a bogus register write in igc_if_queues_free()
ClosedPublic

Authored by markj on Oct 26 2024, 5:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 13, 11:55 PM
Unknown Object (File)
Tue, Sep 23, 4:35 AM
Unknown Object (File)
Sat, Sep 20, 7:49 PM
Unknown Object (File)
Sep 12 2025, 11:14 PM
Unknown Object (File)
Sep 12 2025, 1:16 AM
Unknown Object (File)
Sep 10 2025, 4:28 AM
Unknown Object (File)
Sep 7 2025, 8:02 AM
Unknown Object (File)
Sep 5 2025, 3:04 PM
Subscribers

Details

Summary

As explained in PR 277038, iflib calls IFDI_DETACH() and then
IFDI_QUEUES_FREE(). With igc, the latter writes to a register after it
has been unmapped.

igc_if_detach() already calls igc_release_hw_control(), and looking at
callers of igc_if_queues_free(), that appears to be sufficient. So,
just remove the igc_release_hw_control() call.

PR: 277038
Diagnosed by: Mike Belanger <mibelanger@qnx.com>

Test Plan

I have no igc hardware and can't test this, any testing would be appreciated.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable