Page MenuHomeFreeBSD

igc: Fix a bogus register write in igc_if_queues_free()
ClosedPublic

Authored by markj on Oct 26 2024, 5:22 PM.
Tags
None
Referenced Files
F151494442: D47293.diff
Wed, Apr 8, 8:02 PM
F151484587: D47293.id145492.diff
Wed, Apr 8, 5:54 PM
F151473801: D47293.id145492.diff
Wed, Apr 8, 3:45 PM
Unknown Object (File)
Wed, Apr 8, 1:33 AM
Unknown Object (File)
Mon, Apr 6, 9:18 PM
Unknown Object (File)
Sun, Apr 5, 3:53 PM
Unknown Object (File)
Sat, Mar 21, 7:46 PM
Unknown Object (File)
Sat, Mar 14, 11:43 PM
Subscribers

Details

Summary

As explained in PR 277038, iflib calls IFDI_DETACH() and then
IFDI_QUEUES_FREE(). With igc, the latter writes to a register after it
has been unmapped.

igc_if_detach() already calls igc_release_hw_control(), and looking at
callers of igc_if_queues_free(), that appears to be sufficient. So,
just remove the igc_release_hw_control() call.

PR: 277038
Diagnosed by: Mike Belanger <mibelanger@qnx.com>

Test Plan

I have no igc hardware and can't test this, any testing would be appreciated.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable