Page MenuHomeFreeBSD

igc: Fix a bogus register write in igc_if_queues_free()
ClosedPublic

Authored by markj on Oct 26 2024, 5:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 11, 1:26 PM
Unknown Object (File)
Fri, Sep 11, 9:32 AM
Unknown Object (File)
Wed, Aug 26, 5:43 AM
Unknown Object (File)
Aug 12 2026, 6:43 PM
Unknown Object (File)
Aug 12 2026, 6:37 PM
Unknown Object (File)
Aug 12 2026, 6:26 PM
Unknown Object (File)
Aug 10 2026, 3:06 PM
Unknown Object (File)
Aug 10 2026, 2:13 PM
Subscribers

Details

Summary

As explained in PR 277038, iflib calls IFDI_DETACH() and then
IFDI_QUEUES_FREE(). With igc, the latter writes to a register after it
has been unmapped.

igc_if_detach() already calls igc_release_hw_control(), and looking at
callers of igc_if_queues_free(), that appears to be sufficient. So,
just remove the igc_release_hw_control() call.

PR: 277038
Diagnosed by: Mike Belanger <mibelanger@qnx.com>

Test Plan

I have no igc hardware and can't test this, any testing would be appreciated.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable