Page MenuHomeFreeBSD

tests/sys/fs/fusefs: include iomanip header
ClosedPublic

Authored by ngie on Oct 19 2024, 3:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 30, 5:44 PM
Unknown Object (File)
Wed, Nov 27, 7:50 PM
Unknown Object (File)
Sun, Nov 17, 8:56 AM
Unknown Object (File)
Tue, Nov 12, 2:15 AM
Unknown Object (File)
Mon, Nov 11, 12:26 AM
Unknown Object (File)
Oct 30 2024, 7:25 PM
Unknown Object (File)
Oct 27 2024, 7:43 AM
Unknown Object (File)
Oct 23 2024, 9:05 AM
Subscribers

Details

Summary

io.cc relies on std::setw(..), which is exported by the iomanip C++
header. Newer versions of GoogleTest don't export this header, so add
the explicit include.

This unbreaks the build with GoogleTest 1.15.2.

Test Plan

With GoogleTest 1.15.2...

$ sudo kyua test -k /usr/tests/sys/fs/fusefs/Kyuafile 
access:main  ->  passed  [0.004s]
allow_other:main  ->  passed  [0.004s]
bad_server:main  ->  passed  [0.004s]
bmap:main  ->  passed  [0.004s]
cache:main  ->  passed  [0.004s]
copy_file_range:main  ->  passed  [0.004s]
create:main  ->  passed  [0.005s]
default_permissions:main  ->  passed  [0.008s]
default_permissions_privileged:main  ->  passed  [0.004s]
destroy:main  ->  passed  [0.004s]
dev_fuse_poll:main  ->  passed  [0.005s]
fallocate:main  ->  passed  [0.005s]
fifo:main  ->  passed  [0.003s]
flush:main  ->  passed  [0.004s]
forget:main  ->  passed  [0.004s]
fsync:main  ->  passed  [0.004s]
fsyncdir:main  ->  passed  [0.004s]
getattr:main  ->  passed  [0.004s]
interrupt:main  ->  passed  [0.005s]
io:main  ->  passed  [0.019s]
last_local_modify:main  ->  passed  [0.004s]
link:main  ->  passed  [0.004s]
locks:main  ->  passed  [0.004s]
lookup:main  ->  passed  [0.004s]
lseek:main  ->  passed  [0.004s]
mkdir:main  ->  passed  [0.005s]
mknod:main  ->  passed  [0.004s]
mount:main  ->  passed  [0.004s]
nfs:main  ->  passed  [0.004s]
notify:main  ->  passed  [0.004s]
open:main  ->  passed  [0.004s]
opendir:main  ->  passed  [0.004s]
read:main  ->  passed  [0.006s]
readdir:main  ->  passed  [0.005s]
readlink:main  ->  passed  [0.004s]
release:main  ->  passed  [0.004s]
releasedir:main  ->  passed  [0.004s]
rename:main  ->  passed  [0.004s]
rmdir:main  ->  passed  [0.004s]
setattr:main  ->  passed  [0.005s]
statfs:main  ->  passed  [0.004s]
symlink:main  ->  passed  [0.005s]
unlink:main  ->  passed  [0.004s]
write:main  ->  passed  [0.006s]
xattr:main  ->  passed  [0.005s]

Results file id is usr_tests_sys_fs_fusefs.20241019-161053-827197
Results saved to /root/.kyua/store/results.usr_tests_sys_fs_fusefs.20241019-161053-827197.db

45/45 passed (0 broken, 0 failed, 0 skipped)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ngie requested review of this revision.Oct 19 2024, 3:36 PM
ngie edited the summary of this revision. (Show Details)
ngie retitled this revision from Include iomanip header to tests/sys/fs/fusefs: include iomanip header.
ngie edited subscribers, added: tests; removed: asomers.

The change LGTM. But the tests ran suspiciously fast. Are you sure that fusefs.ko is loaded?

This revision is now accepted and ready to land.Oct 19 2024, 5:13 PM
This revision was automatically updated to reflect the committed changes.