Page MenuHomeFreeBSD
Differential D47148

nscd step6
Needs ReviewPublic
Actions

Authored by david_crossfamilyweb.com on Oct 16 2024, 3:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 16, 2:10 PM
Unknown Object (File)
Fri, Jan 16, 10:04 AM
Unknown Object (File)
Wed, Jan 14, 5:51 PM
Unknown Object (File)
Wed, Jan 14, 2:19 AM
Unknown Object (File)
Sat, Jan 10, 9:27 AM
Unknown Object (File)
Thu, Jan 8, 10:14 AM
Unknown Object (File)
Wed, Dec 24, 7:29 AM
Unknown Object (File)
Dec 14 2025, 10:25 AM
View All 55 Files
Subscribers
imp

Details

Reviewers
markj
Summary

minor code quality fixups for getpwent.
implement libc side of grouplist and pivot lookups for caching

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

david_crossfamilyweb.com created this revision.Oct 16 2024, 3:10 AM
Herald added a subscriber: imp. · View Herald TranscriptOct 16 2024, 3:10 AM
david_crossfamilyweb.com requested review of this revision.Oct 16 2024, 3:10 AM
markj added inline comments.Oct 17 2024, 3:02 PM
lib/libc/gen/getgrent.c
209
370

original_ngroups is an "untrusted" value, i.e., it comes from nscd. This code should at least verify that

  1. it's non-negative,
  2. that original_ngroups * sizeof(gid_t) won't overflow,

before doing math with it.

david_crossfamilyweb.com updated this revision to Diff 145071.Oct 18 2024, 5:44 AM

Implemented all PR changes

david_crossfamilyweb.com mentioned this in D38047: Multiple fixes to the NSS caching system.Aug 6 2025, 11:02 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
gen/
120 lines
6 lines
include/
3 lines

Diff 145071

View Options

lib/libc/gen/getgrent.c

Loading...
View Options

lib/libc/gen/getpwent.c

Loading...
View Options

lib/libc/include/nscachedcli.h

Loading...