Fixes for nscd.
- rename the symbol in nscd, not exported in Makefile yet, so not a visible change
- fix negative cache response for agent lookups
Details
Details
- Reviewers
markj
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
| usr.sbin/nscd/nscd.c | ||
|---|---|---|
| 587 | Thinking about this a bit more - suppose someone else has locally fixed the problem in nscd, where the symbol doesn't get exported. Now we're gratuitously making libc incompatible with their nscd. That is, if they upgrade libc, their nscd will stop working properly, but libc should always avoid breaking backwards compatibility. The likelihood of this happening is small, so the change is unlikely to cause problems, but the advantage of the change is also very small. I don't insist on dropping this change, but I don't really like it. | |
| usr.sbin/nscd/query.c | ||
| 809 | It's not obvious to me that we want to make this change for the res == NS_RETURN case, but none of the existing lookup functions appear to return that, so ok. | |