net-im/libsignal-node: Fix poudriere build

[jrm]

Summary

After the update to 0.58.0, the port failed to build in poudriere during
the fetch phase, giving the error:

make: Could not create temporary file
/wrkdirs/usr/ports/net-im/libsignal-node/work/makekSsI9M: No such file
or directory

Instead of removing ${WRKDIR} in the pre-fetch phase, clearing its
contents resolves the issue and allows the build to succeed.

[jrm]

net-im/libsignal-node/Makefile

71–72

If we want to be cautious, we could instead use [ -d "${WRKDIR}" ] && ${RM} -r ${WRKDIR:?}/*; \ or ${RM} -r ${WRKDIR} && ${MKDIR} ${WRKDIR}; \.

[mikael]

Sorry, this was fixed in https://cgit.freebsd.org/ports/commit/net-im/libsignal-node/Makefile?id=858d32fac8f9ab1d211abaa8fed7d3f1c443f7c4 and reintroduce in
https://cgit.freebsd.org/ports/commit/net-im/libsignal-node/Makefile?id=57741b0aa4123a69b1fd223fde4a70ca82283edb.
I forgot to merge this change in https://github.com/MikaelUrankar/signal-desktop

You have my implicit approval to fix my stupid mistakes

Thank you.

[jrm]

In D46966#1070659, @mikael wrote:

Sorry, this was fixed in https://cgit.freebsd.org/ports/commit/net-im/libsignal-node/Makefile?id=858d32fac8f9ab1d211abaa8fed7d3f1c443f7c4 and reintroduce in
https://cgit.freebsd.org/ports/commit/net-im/libsignal-node/Makefile?id=57741b0aa4123a69b1fd223fde4a70ca82283edb.

In that case, I'll completely remove the "${RM}" to match your previous fix. Given you did this in the past, I assume there is no harm in leaving the temporary ${WRKDIR} contents around.

I forgot to merge this change in https://github.com/MikaelUrankar/signal-desktop

You have my implicit approval to fix my stupid mistakes

Thank you.

Thanks for clarifying the issue.