Page MenuHomeFreeBSD

zdb: report an error if initialisation fails
ClosedPublic

Authored by bapt on Dec 22 2015, 11:14 PM.

Details

Summary

Right now zdb crashes if for various reasons libzfs_init fails which can happen
if the zfs modules fails to load for example.

I think it is better to reportean error rather than crashing

If you want I can also upstream this patch to openzfs

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

bapt updated this revision to Diff 11622.Dec 22 2015, 11:14 PM
bapt retitled this revision from to zdb: report an error if initialisation fails.
bapt updated this object.
bapt edited the test plan for this revision. (Show Details)
bapt added a reviewer: mahrens.
bapt updated this object.Dec 22 2015, 11:16 PM
mahrens edited edge metadata.Dec 23 2015, 12:02 AM

looks good. Happy to have this upstream too.

mahrens accepted this revision.Dec 23 2015, 12:02 AM
mahrens edited edge metadata.
This revision is now accepted and ready to land.Dec 23 2015, 12:02 AM
This revision was automatically updated to reflect the committed changes.