zdb: report an error if initialisation fails
ClosedPublic
Actions

Authored by bapt on Dec 22 2015, 11:14 PM.

Details

Reviewers

Commits

rS297089: MFC r292653 (by bapt): Report an error if zdb cannot initialize zfs
rS292653: Report an error if zdb cannot initialize zfs

Summary

Right now zdb crashes if for various reasons libzfs_init fails which can happen
if the zfs modules fails to load for example.

I think it is better to reportean error rather than crashing

If you want I can also upstream this patch to openzfs

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt updated this revision to Diff 11622.Dec 22 2015, 11:14 PM

bapt retitled this revision from to zdb: report an error if initialisation fails.

bapt updated this object.

bapt edited the test plan for this revision. (Show Details)

bapt added a reviewer: mahrens.

Herald added a subscriber: imp. · View Herald TranscriptDec 22 2015, 11:14 PM

bapt updated this object.Dec 22 2015, 11:16 PM

looks good. Happy to have this upstream too.

mahrens accepted this revision.Dec 23 2015, 12:02 AM

mahrens edited edge metadata.

This revision is now accepted and ready to land.Dec 23 2015, 12:02 AM

Closed by commit rS292653: Report an error if zdb cannot initialize zfs (authored by bapt). · Explain WhyDec 23 2015, 10:21 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

cddl/

contrib/

opensolaris/

cmd/

zdb/

zdb.c

3 lines

Diff 11627

View Options

head/cddl/contrib/opensolaris/cmd/zdb/zdb.c

zdb: report an error if initialisation failsClosedPublicActions