Page MenuHomeFreeBSD

Adding QEMU Virtualization to Handbook
ClosedPublic

Authored by jpb_jimby.name on Sep 12 2024, 8:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 29, 12:10 AM
Unknown Object (File)
Nov 11 2024, 8:05 PM
Unknown Object (File)
Oct 27 2024, 6:20 AM
Unknown Object (File)
Oct 25 2024, 2:49 AM
Unknown Object (File)
Oct 6 2024, 9:39 PM
Unknown Object (File)
Oct 6 2024, 5:58 PM
Unknown Object (File)
Oct 6 2024, 2:28 PM
Unknown Object (File)
Oct 5 2024, 8:44 PM

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 59635
Build 56522: arc lint + arc unit

Event Timeline

jpb_jimby.name created this revision.
jpb_jimby.name edited the summary of this revision. (Show Details)

Fixed FreeBSD download link to use dvd1.

Nothing major. I may have missed some of those in my initial review. Nice doc overall.

documentation/content/en/books/handbook/virtualization/_index.adoc
520
525
562

I'd use the month itself instead, if known. (Not all our users are in the same hemisphere.)

567โ€“568

Instead, I'd use % (not root) or # (root) shell prompts as done in the rest of the handbook and stated in https://docs.freebsd.org/en/books/handbook/preface/#preface-conv .

638โ€“646
658

I'd like someone more familiar with QEMU and system administration than me to look at the use of sudo here. I'll just note that to me it sounds inconsistent with the suggestion to add a -runas option below.

698
704
744

Same remark here as for the sudo in left.sh above.

859

And again re sudo

949
1027
1083

If you keep the sudo in left.sh below, do you also need the one here?

1091

Same here re sudo in scripts.

1137
1217

Here too I'd use the month if known.

1276
jpb_jimby.name added inline comments.
documentation/content/en/books/handbook/virtualization/_index.adoc
658

I've removed all the "sudo" statements and replaced with the root prompt "#". The "-runas" option is designed to run the QEMU command but drop privileges before running the VM.

From QEMU(1):

-runas user
       Immediately before starting guest execution, drop root
       privileges, switching to the specified user.
698

edited as "... metadata during first use" instead of "metadata during the first use".

1083

I've changed out all "sudo" and replaced with the root prompt "#".

1091

Same as above. Also, in this example I removed the text
"# left VM script" since it could be misunderstood as a command run as root.

I did the same for the script listing at line 853.

Seems like the latest diff hasn't been uploaded yet, but once it is uploaded, I think this is ready to land?

Resubmitting changes - some did not get noted as "Submitted".

Typos and small changes from last Pau Amma review.

This revision was not accepted when it landed; it landed in state Needs Review.Sep 27 2024, 9:02 PM
Closed by commit R9:3de85d772f3e: virtualization: Add chapter on QEMU (authored by jpb_jimby.name, committed by debdrup). ยท Explain Why
This revision was automatically updated to reflect the committed changes.