Page MenuHomeFreeBSD

usb: change LIST to SLIST to avoid LinuxKPI conflicts
AcceptedPublic

Authored by bz on Wed, Sep 4, 7:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 9, 9:39 AM
Unknown Object (File)
Sun, Sep 8, 6:03 AM
Unknown Object (File)
Sat, Sep 7, 5:04 PM
Unknown Object (File)
Wed, Sep 4, 7:38 PM
Subscribers

Details

Reviewers
emaste
Group Reviewers
USB
Summary

In order to better integrate modern LinuxKPI USB this tries to reduce
a contention point of "LIST". Given there is no need to us a LIST here
change it to SLIST to avoid conflicts.

Sponsored by: The FreeBSD Foundation
X-MFC? unclear

Test Plan

Manually extract from a larger change in a different branch;
make universe for amd64/arm64 are running.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 59304
Build 56191: arc lint + arc unit

Event Timeline

bz requested review of this revision.Wed, Sep 4, 7:28 PM

I think this is fine even if it's sort of a lucky workaround (we still mix Linux and FreeBSD namespaces, we're just capitalizing on Linux's lack of SLIST it seems).

sys/dev/usb/usb_device.c
2269

extra blank line?

This revision is now accepted and ready to land.Fri, Sep 13, 1:38 PM