kldxref: Don't warn and skip file if no relocations are found
ClosedPublic
Actions

Authored by jrtc27 on Sep 2 2024, 9:52 PM.

Details

Reviewers

jhb
imp

Commits

rG9c9f4654e4db: kldxref: Don't warn and skip file if no relocations are found
rG0e3963317e14: kldxref: Don't warn and skip file if no relocations are found
rG05996f453de2: kldxref: Don't warn and skip file if no relocations are found

Summary

This case is hit for the kernel itself on riscv64, and did not used to
be checked. Since the code here can already handle missing Elf_Rel
and/or Elf_Rela just delete the check.

Fixes: 0299afdff145 ("kldxref: Make use of libelf to be a portable cross tool")
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jrtc27 created this revision.Sep 2 2024, 9:52 PM

Herald added a subscriber: imp. · View Herald TranscriptSep 2 2024, 9:52 PM

jrtc27 requested review of this revision.Sep 2 2024, 9:52 PM

Harbormaster completed remote builds in B59284: Diff 142746.Sep 2 2024, 9:53 PM

Seems legit

This revision is now accepted and ready to land.Sep 2 2024, 9:59 PM

jhb accepted this revision.Sep 4 2024, 7:44 PM

Closed by commit rG05996f453de2: kldxref: Don't warn and skip file if no relocations are found (authored by jrtc27). · Explain WhySep 10 2024, 5:57 PM

This revision was automatically updated to reflect the committed changes.

jrtc27 added a commit: rG05996f453de2: kldxref: Don't warn and skip file if no relocations are found.

jrtc27 added a commit: rG0e3963317e14: kldxref: Don't warn and skip file if no relocations are found.Mon, Dec 15, 5:01 PM

jrtc27 added a commit: rG9c9f4654e4db: kldxref: Don't warn and skip file if no relocations are found.Mon, Dec 15, 6:19 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

kldxref/

ef.c

5 lines

Diff 143203

View Options

kldxref: Don't warn and skip file if no relocations are foundClosedPublicActions