Page MenuHomeFreeBSD

ena: Fix customer metrics deallocation statement place
Needs ReviewPublic

Authored by osamaabb_amazon.com on Aug 20 2024, 8:46 AM.
Tags
None
Referenced Files
F135858307: D46354.id142213.diff
Thu, Nov 13, 2:32 PM
Unknown Object (File)
Tue, Nov 4, 3:42 AM
Unknown Object (File)
Thu, Oct 30, 11:07 AM
Unknown Object (File)
Wed, Oct 29, 9:02 AM
Unknown Object (File)
Wed, Oct 29, 6:45 AM
Unknown Object (File)
Wed, Oct 29, 6:31 AM
Unknown Object (File)
Mon, Oct 27, 12:35 AM
Unknown Object (File)
Sun, Oct 26, 12:30 AM
Subscribers

Details

Reviewers
cperciva
Summary

Upstream commit [1] made if_alloc_domain() never fail, then also do the
wrappers if_alloc(), if_alloc_dev(), and if_gethandle().

Upstream commit [2] removed the NULL check conducted by the driver.
This commit also removes err_customer_metrics_alloc goto label.

Commit [2] leaves behind a floating free() statement that
deallocates customer_metrics_array. This commit places the
deallocation statement where it belongs.

[1] commit 4787572d0580 ("ifnet: make if_alloc_domain() never fail")
[2] commit aa3860851b9f ("net: Remove unneeded NULL check for the allocated ifnet")

Approved by: cperciva
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 59083
Build 55970: arc lint + arc unit