ena: PHC destroy race

[osamaabb_amazon.com]

Summary

Under theoretical race condition, PHC may be destroyed while PHC
timestamp is retrieved. This will cause the PHC device memory to
be freed while being used in another thread.
To prevent such a race, PHC destroy flow will disable the PHC state
under PHC lock, (these lock and state variables are used on every
PHC timestamp retrieval).

Approved by: cperciva
MFC after: 2 weeks
Sponsored by: Amazon, Inc.

[cperciva]

sys/contrib/ena-com/ena_com.c

1887

Seems weird to add a new value flags=0 and then use it a few lines later without any way for the flags to change. Is this Amazon house style saying "no magic numbers"?

[osamaabb_amazon.com]

sys/contrib/ena-com/ena_com.c

1887

We do hate magic number or using variables uninitialized, we do our best to avoid doing that