`
ClosedPublic
Actions

Authored by brooks on Aug 6 2024, 12:25 AM.

Tags

None

Referenced Files

	F167065785: D46233.id141861.diff
	Tue, Aug 18, 8:31 PM

	F167056910: D46233.id141841.diff
	Tue, Aug 18, 8:11 PM

	F167018415: D46233.diff
	Tue, Aug 18, 3:05 PM

	Unknown Object (File)
	Sun, Aug 16, 8:18 PM

	Unknown Object (File)
	Thu, Aug 13, 12:24 PM

	Unknown Object (File)
	Thu, Aug 13, 12:23 PM

	Unknown Object (File)
	Fri, Aug 7, 4:23 PM

	Unknown Object (File)
	May 28 2026, 11:46 PM

View All 86 Files

Subscribers

None

Details

Reviewers

imp
jhb

Commits

rGb5c95c93fdd4: sys/mman.h: consistently use `#define<tab>`

Summary

There were 12 cases of #define<space> and 91 of #define<tab> and in
some cases like msync() flags (MS_*) there wasn't consistency.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brooks requested review of this revision.Aug 6 2024, 12:25 AM

brooks created this revision.

Harbormaster completed remote builds in B58951: Diff 141841.Aug 6 2024, 12:25 AM

I noticed the inconsistent MS_ flags when looking at a CheriBSD diff and it seemed worth fixing. I'll follow up with a commit to .git-blame-ignore-revs once this lands.

It's about 50/50 in the tree. Style(9) sez tabs

This revision is now accepted and ready to land.Aug 6 2024, 1:13 AM

Closed by commit rGb5c95c93fdd4: sys/mman.h: consistently use `#define<tab>` (authored by brooks). · Explain WhyAug 6 2024, 6:19 PM

This revision was automatically updated to reflect the committed changes.

brooks added a commit: rGb5c95c93fdd4: sys/mman.h: consistently use `#define<tab>`.

Revision Contents
Changeset List

Path

Size

sys/

mman.h

24 lines

Diff 141861

View Options

sys/mman.h: consistently use `#define<tab>`ClosedPublicActions