Page MenuHomeFreeBSD

ls: Make -, apply to -s as well as -l.
ClosedPublic

Authored by des on Jul 22 2024, 8:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 7, 12:11 PM
Unknown Object (File)
Mon, Oct 6, 9:26 PM
Unknown Object (File)
Fri, Oct 3, 5:17 PM
Unknown Object (File)
Tue, Sep 23, 2:01 PM
Unknown Object (File)
Mon, Sep 22, 10:59 PM
Unknown Object (File)
Sep 9 2025, 10:28 PM
Unknown Object (File)
Aug 26 2025, 12:44 PM
Unknown Object (File)
Jul 24 2025, 3:04 AM
Subscribers

Details

Summary

While here, remove a bogus comment about a gcc bug. The bug was in ls,
which used an incorrect format string, and in libc, which accepted it.

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.Jul 22 2024, 8:14 PM

Note that, independently of this change, I'm not convinced ls -s reports the right information. It seems to assume that the block size is fixed and universal, while on ZFS it can vary from one file to another. I believe ls should switch to keeping blocksize in bytes and printing howmany(st_blocks * st_blksize, blocksize) instead of keeping blocksize in units of 512 bytes and printing howmany(st_blocks, blocksize).

Ignore this, st_blocks is always in units of 512 bytes, not in units of st_blksize.

This revision is now accepted and ready to land.Jul 24 2024, 7:20 PM
This revision was automatically updated to reflect the committed changes.