pci: Narrow the scope of recently-added PCI_IOV #ifdefs
ClosedPublic
Actions

Authored by jhb on Jul 5 2024, 3:17 PM.

Details

Reviewers

Commits

rGa27c361e0503: pci: Narrow the scope of recently-added PCI_IOV #ifdefs
rG971c9f57d7e6: pci: Narrow the scope of recently-added PCI_IOV #ifdefs

Summary

Push the #ifdefs down into the function body instead of defining
functions conditionally for ease of readability. These aren't
critical paths, so one extra branch in the !PCI_IOV case is not a big
deal.

Requested by: jrtc27

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Jul 5 2024, 3:17 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 5 2024, 3:17 PM

jhb requested review of this revision.Jul 5 2024, 3:17 PM

Harbormaster completed remote builds in B58507: Diff 140573.Jul 5 2024, 3:17 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 8 2024, 7:42 PM

Closed by commit rG971c9f57d7e6: pci: Narrow the scope of recently-added PCI_IOV #ifdefs (authored by jhb). · Explain Why

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG971c9f57d7e6: pci: Narrow the scope of recently-added PCI_IOV #ifdefs.

jhb added a commit: rGa27c361e0503: pci: Narrow the scope of recently-added PCI_IOV #ifdefs.Feb 27 2025, 2:18 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

pci/

pci.c

14 lines

Diff 141929

View Options

pci: Narrow the scope of recently-added PCI_IOV #ifdefsClosedPublicActions