Page MenuHomeFreeBSD
Differential D45877

pci: Narrow the scope of recently-added PCI_IOV #ifdefs
ClosedPublic
Actions

Authored by jhb on Jul 5 2024, 3:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 9:15 PM
Unknown Object (File)
Jan 6 2025, 5:24 AM
Unknown Object (File)
Dec 24 2024, 9:27 AM
Unknown Object (File)
Nov 14 2024, 8:50 PM
Unknown Object (File)
Nov 5 2024, 11:40 AM
Unknown Object (File)
Nov 4 2024, 5:19 AM
Unknown Object (File)
Oct 9 2024, 10:13 AM
Unknown Object (File)
Sep 25 2024, 10:40 AM
View All 29 Files
Subscribers
imp

Details

Reviewers
jrtc27
Commits
rG971c9f57d7e6: pci: Narrow the scope of recently-added PCI_IOV #ifdefs
Summary

Push the #ifdefs down into the function body instead of defining
functions conditionally for ease of readability. These aren't
critical paths, so one extra branch in the !PCI_IOV case is not a big
deal.

Requested by: jrtc27

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb created this revision.Jul 5 2024, 3:17 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 5 2024, 3:17 PM
jhb requested review of this revision.Jul 5 2024, 3:17 PM
Harbormaster completed remote builds in B58507: Diff 140573.Jul 5 2024, 3:17 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 8 2024, 7:42 PM
Closed by commit rG971c9f57d7e6: pci: Narrow the scope of recently-added PCI_IOV #ifdefs (authored by jhb). · Explain Why
This revision was automatically updated to reflect the committed changes.
jhb added a commit: rG971c9f57d7e6: pci: Narrow the scope of recently-added PCI_IOV #ifdefs.

Revision Contents
Changeset List

PathSize
sys/
dev/
pci/
14 lines

Diff 141929

View Options

sys/dev/pci/pci.c

Loading...