Is this a good place to add a brief note about why this is a good idea, either in the commit message or in the code? (If so, I'd lean towards the former).

This revision is now accepted and ready to land.Sun, Jun 2, 6:57 PM

jhb added a child revision: D45308: nvmf: Permit failing I/O requests while disconnected.Sun, Jun 2, 7:41 PM

jhb added a child revision: D45462: nvmf: Handle shutdowns more gracefully.Sun, Jun 2, 7:53 PM

jhb removed a child revision: D45462: nvmf: Handle shutdowns more gracefully.

In D45461#1036800, @imp wrote:

Is this a good place to add a brief note about why this is a good idea, either in the commit message or in the code? (If so, I'd lean towards the former).

Oh, yeah, I probably should note that a namespace could have been removed or added while we were disconnected in the log message. That's the use case, though after the change to optionally fail I/O's while disconnected it is also needed to "see" existing namespaces after a reconnect. For this commit though in the time sequence it is just the "something changed while disconnected" (which is also how I tested it, using ctladm to add/remove LUNs on the server side while the client was disconnected).

Closed by commit rGe140f85dc194: nvmf: Rescan namespaces after reconnecting (authored by jhb). · Explain WhyWed, Jun 5, 8:04 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGe140f85dc194: nvmf: Rescan namespaces after reconnecting.