Paths

Table of Contentst

Differential D45441

Summary: Migrate from printb to print_bits for locally defined bit fields.
ClosedPublic
Actions

Authored by gordon on Sat, Jun 1, 3:57 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jun 21, 4:20 PM

	Unknown Object (File)
	Wed, Jun 12, 10:16 PM

	Unknown Object (File)
	Wed, Jun 12, 9:25 PM

	Unknown Object (File)
	Wed, Jun 12, 9:24 PM

	Unknown Object (File)
	Wed, Jun 12, 3:29 PM

	Unknown Object (File)
	Tue, Jun 11, 2:49 PM

	Unknown Object (File)
	Sat, Jun 8, 4:32 AM

	Unknown Object (File)
	Thu, Jun 6, 6:33 PM

View All 11 Files

Subscribers

Details

Reviewers

emaste
jhb

Commits

rGa68e4f7a0652: Migrate from printb to print_bits for locally defined bit fields.
rGc3e9423743d9: Move print_bits to ifconfig.c and make available to other src files.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gordon created this revision.Sat, Jun 1, 3:57 PM

Herald added a subscriber: imp. · View Herald TranscriptSat, Jun 1, 3:58 PM

gordon requested review of this revision.Sat, Jun 1, 3:58 PM

Harbormaster completed remote builds in B57991: Diff 139306.Sat, Jun 1, 3:59 PM

emaste added inline comments.Sat, Jun 1, 4:36 PM

sbin/ifconfig/af_nd6.c
56 ↗	(On Diff #139306)
66–67 ↗	(On Diff #139306)	you could move the `#ifdef` to just make these two conditional now?
181 ↗	(On Diff #139306)	If refactoring I'd drop this pseduo-bit-15 hack here and just add a `if (isdefif) printf("...")` assuming `isdefif` is in fact boolean and there isn't some magic here

gordon marked 2 inline comments as done.Mon, Jun 3, 3:02 PM

gordon added inline comments.

sbin/ifconfig/af_nd6.c
181 ↗	(On Diff #139306)	I don't think I'm going to try to change the logic here. At least not with this change.

Address comments from emaste.

Harbormaster completed remote builds in B58015: Diff 139353.Mon, Jun 3, 3:05 PM

emaste accepted this revision.Mon, Jun 3, 3:16 PM

This revision is now accepted and ready to land.Mon, Jun 3, 3:16 PM

Move print_bits to ifconfig.c and make available to other src files.
Migrate from printb to print_bits for locally defined bit fields.

This revision now requires review to proceed.Mon, Jun 3, 3:18 PM

Harbormaster completed remote builds in B58016: Diff 139354.Mon, Jun 3, 3:18 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mon, Jun 3, 3:52 PM

Closed by commit rGc3e9423743d9: Move print_bits to ifconfig.c and make available to other src files. (authored by gordon). · Explain Why

This revision was automatically updated to reflect the committed changes.

gordon added a commit: rGc3e9423743d9: Move print_bits to ifconfig.c and make available to other src files..

gordon added a commit: rGa68e4f7a0652: Migrate from printb to print_bits for locally defined bit fields..

Revision Contents
Changeset List

Path

Size

sbin/

ifconfig/

2 lines

23 lines

ifconfig_netlink.c

23 lines

Diff 139356

sbin/ifconfig/ifconfig.h

Loading...

sbin/ifconfig/ifconfig.c

Loading...

sbin/ifconfig/ifconfig_netlink.c

Loading...