Summary: Migrate from printb to print_bits for locally defined bit fields.

[emaste]

sbin/ifconfig/af_nd6.c

56 ↗

(On Diff #139306)

66–67 ↗

(On Diff #139306)

you could move the #ifdef to just make these two conditional now?

181 ↗

(On Diff #139306)

If refactoring I'd drop this pseduo-bit-15 hack here and just add a if (isdefif) printf("...")
assuming isdefif is in fact boolean and there isn't some magic here

[gordon]

sbin/ifconfig/af_nd6.c

181 ↗

(On Diff #139306)

I don't think I'm going to try to change the logic here. At least not with this change.

[gordon]

Address comments from emaste.

[gordon]

• Move print_bits to ifconfig.c and make available to other src files.
• Migrate from printb to print_bits for locally defined bit fields.

[zarychtam_plan-b.pwste.edu.pl]

Will it be feasible to officially MFC this to stable/14? Old code prevents MFC of the upcoming " Implement IPV6 RFC 7217", currently in review D49681.

[zarychtam_plan-b.pwste.edu.pl]

I am referring to this serie of commits:
commit a68e4f7a065218f0bcc5b34ff8d2e73a240b59b2
Author: Gordon Tetlow <[e-mail]>
Date: Fri May 31 13:58:52 2024 -0700

Migrate from printb to print_bits for locally defined bit fields.

Reviewed by:    emaste
Event:          Kitchener-Waterloo Hackathon 202406
Differential Revision:  https://reviews.freebsd.org/D45441

commit c3e9423743d91ae5b5865602a905900a1855055e
Author: Gordon Tetlow <[e-mail]>
Date: Fri May 31 13:48:10 2024 -0400

Move print_bits to ifconfig.c and make available to other src files.

Reviewed by:    emaste
Event:          Kitchener-Waterloo Hackathon 202406
Differential Revision:  https://reviews.freebsd.org/D45441

The first one is problematic, but probably both have to be MFCed together.

[zarychtam_plan-b.pwste.edu.pl]

Please ignore. It should be possible to cherry-pick D49681 after it lands without MFC of the above.