Differential D44908

geli.8: add some notes regarding performance tuning
ClosedPublic
Actions

Authored by asomers on Apr 22 2024, 10:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, May 12, 1:19 AM

	Unknown Object (File)
	Tue, May 12, 1:19 AM

	Unknown Object (File)
	Tue, May 12, 12:45 AM

	Unknown Object (File)
	Tue, May 12, 12:22 AM

	Unknown Object (File)
	Wed, May 6, 10:01 PM

	Unknown Object (File)
	Mon, May 4, 3:02 PM

	Unknown Object (File)
	Sun, May 3, 6:42 PM

	Unknown Object (File)
	Thu, Apr 30, 8:53 AM

Subscribers

Details

Reviewers

Commits

rG4b7949144cfb: geli.8: add some notes regarding performance tuning

Summary

MFC after: 1 weel
Sponsored by: Axcient

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Apr 22 2024, 10:33 PM

Herald added a subscriber: imp. · View Herald TranscriptApr 22 2024, 10:33 PM

asomers requested review of this revision.Apr 22 2024, 10:33 PM

Harbormaster completed remote builds in B57284: Diff 137529.Apr 22 2024, 10:33 PM

markj added inline comments.Apr 23 2024, 4:00 PM

lib/geom/eli/geli.8
859
861
913	Maybe also note that this variable needs to be set before the volume is attached. It's confusing that the default value is 0 when that really means it's equal to NCPU.
920	or combine with the previous sentence.

asomers marked 3 inline comments as done.Apr 23 2024, 5:26 PM

asomers added inline comments.

lib/geom/eli/geli.8
913	Ok. I added that note to the previous section.

Respond to markj's feedback.

Harbormaster completed remote builds in B57305: Diff 137567.Apr 23 2024, 5:27 PM

Seems ok, thank you. I included a couple of suggestions.

lib/geom/eli/geli.8
856
923

This revision is now accepted and ready to land.Apr 24 2024, 12:38 PM

Closed by commit rG4b7949144cfb: geli.8: add some notes regarding performance tuning (authored by asomers). · Explain WhyApr 24 2024, 1:54 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rG4b7949144cfb: geli.8: add some notes regarding performance tuning.

asomers mentioned this in rG1c5b58a71718: geli.8: minor proofreading.May 9 2024, 8:25 PM

Revision Contents
Changeset List

Path

Size

lib/

geom/

eli/

42 lines

Diff 137600

lib/geom/eli/geli.8

Loading...