Page MenuHomeFreeBSD
Differential D44758

sound: Remove leftover references to snd_clone
ClosedPublic
Actions

Authored by christos on Apr 12 2024, 6:40 PM.
Tags
None
Referenced Files
F151926713: D44758.id.diff
Sat, Apr 11, 1:59 PM
F151921682: D44758.id136950.diff
Sat, Apr 11, 1:19 PM
Unknown Object (File)
Sat, Apr 11, 6:09 AM
Unknown Object (File)
Tue, Apr 7, 2:20 AM
Unknown Object (File)
Mar 4 2026, 6:23 PM
Unknown Object (File)
Mar 2 2026, 3:21 PM
Unknown Object (File)
Feb 24 2026, 2:44 PM
Unknown Object (File)
Feb 23 2026, 1:42 AM
View All 78 Files
Subscribers
imp

Details

Reviewers
markj
Commits
rG5abbbb7c6401: sound: Remove leftover references to snd_clone
rG068c675ca7ae: sound: Remove leftover references to snd_clone
Summary

The snd_clone framework does not exist as of
e8c0d15a64fadb4a330f2da7244becaac161bb70 ("sound: Get rid of snd_clone
and use DEVFS_CDEVPRIV(9)"), so remove leftover references to it from
unit.c.

Sponsored by: The FreeBSD Foundation
MFC after: 2 months

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

christos created this revision.Apr 12 2024, 6:40 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 12 2024, 6:40 PM
christos requested review of this revision.Apr 12 2024, 6:40 PM
Harbormaster completed remote builds in B57058: Diff 136950.Apr 12 2024, 6:41 PM
christos added a comment.Apr 12 2024, 6:42 PM

The 2 month MFC is because e8c0d15a64fa will also be MFC'd in 2 months.

markj added inline comments.Apr 13 2024, 5:02 PM
sys/dev/sound/unit.c
49
57

Why is "by design" in quotes?

christos marked an inline comment as done.Apr 13 2024, 5:05 PM
christos added inline comments.
sys/dev/sound/unit.c
57

I do not really know to be honest, but I would assume it doesn't mean much (the fact that it is in quotes).

markj accepted this revision.Apr 13 2024, 5:10 PM
This revision is now accepted and ready to land.Apr 13 2024, 5:10 PM
Closed by commit rG068c675ca7ae: sound: Remove leftover references to snd_clone (authored by christos). · Explain WhyApr 13 2024, 5:12 PM
This revision was automatically updated to reflect the committed changes.
christos added a commit: rG068c675ca7ae: sound: Remove leftover references to snd_clone.
christos added a commit: rG5abbbb7c6401: sound: Remove leftover references to snd_clone.Apr 18 2024, 12:42 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
sound/
20 lines

Diff 136994

View Options

sys/dev/sound/unit.c

Loading...