Page MenuHomeFreeBSD

Enable repeated line compression for lines of any length.
ClosedPublic

Authored by asomers on Dec 9 2015, 5:38 PM.

Details

Summary

Enable repeated line compression for lines of any length, instead of only short
lines. AFAICT repeated line compression was limited to short lines as a RAM
optimization, which made sense when karels added it in 1988, but no longer.
The penalty is a paltry 904B of RAM per file logged.

Test Plan

for i in jot 5 1; do
logger log a really loooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooooong line
done

Verify that the line only shows up once in /var/log/messages

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

asomers updated this revision to Diff 10990.Dec 9 2015, 5:38 PM
asomers retitled this revision from to Enable repeated line compression for lines of any length..
asomers updated this object.
asomers edited the test plan for this revision. (Show Details)
asomers added a reviewer: rpaulo.

Ping. Have you had a chance to review this change?

Ping. Are you ok with this change?

rpaulo accepted this revision.Jan 27 2016, 6:14 AM
rpaulo edited edge metadata.

Please ping me by email directly next time.

This revision is now accepted and ready to land.Jan 27 2016, 6:14 AM
This revision was automatically updated to reflect the committed changes.