Page MenuHomeFreeBSD

- Update to 0.29
ClosedPublic

Authored by miwi on Dec 9 2015, 4:26 PM.

Details

Reviewers
bapt
mat
Group Reviewers
Python
Commits
rP403482: - Update to 0.29

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

miwi retitled this revision from to - Update to 0.29.
miwi updated this object.
miwi edited the test plan for this revision. (Show Details)
miwi added reviewers: mat, bapt.
  • Switch to options helper
mat added inline comments.
devel/py-check-manifest/Makefile
9 ↗(On Diff #10982)

I think the Python rule is that the port and package should match the upstream name.

30–31 ↗(On Diff #10982)

This should be a test target.

koobs added inline comments.
devel/py-check-manifest/Makefile
9 ↗(On Diff #10982)

Odd, i already renamed it:

http://svnweb.freebsd.org/changeset/ports/375773
29 Dec 2014 05:54:37

?

devel/py-check-manifest/Makefile
9 ↗(On Diff #10982)

Ah, but you renamed the directory, not the PORTNAME ^^
Shouldn't they both match ?

devel/py-check-manifest/Makefile
9 ↗(On Diff #10982)

WOW, I *what* ?!@ *looks*

9 ↗(On Diff #10982)

OH WOW. Fail

Yes, PORTNAME should be check-manifest

  • Fix PORTNAME
  • Add NO_ARCH
  • Switch to do-test
devel/py-check-manifest/Makefile
30–31 ↗(On Diff #11024)

Should be imho

DO_MAKE_TEST?=-${SETENV} ${TEST_ENV} ${PYTHON_CMD} ${PYDISTUTILS_SETUP}  ${TEST_TARGET}
TEST_TARGET=test
`

Actually the DO_MAKE_TEST should probably end up in python.mk

I guess we have to fix all following ports as well.

/usr/ports/devel/py-pip/Makefile:do-test:
/usr/ports/devel/py-pluggy/Makefile:do-test:
/usr/ports/devel/py-py/Makefile:do-test:
/usr/ports/devel/py-setproctitle/Makefile:do-test:
/usr/ports/devel/py-tox/Makefile:do-test:
/usr/ports/dns/py-idna/Makefile:do-test:
/usr/ports/security/py-acme/Makefile:do-test:
/usr/ports/security/py-cryptography/Makefile:do-test:
/usr/ports/security/py-letsencrypt/Makefile:do-test:
/usr/ports/www/py-bleach/Makefile:do-test:
/usr/ports/www/py-django-contrib-comments/Makefile:do-test:
/usr/ports/www/py-django-mezzanine/Makefile:do-test:
/usr/ports/www/py-hyper/Makefile:do-test:
/usr/ports/www/py-pelican/Makefile:do-test:
/usr/ports/www/py-requests/Makefile:do-test:
/usr/ports/www/py-requests-oauthlib/Makefile:do-test:

and get something quickly to the python.mk before more ports get this do-test thing.

Agree with @miwi - need to make sure that the test portion doesn't pollute makefiles but gets abstracted into something like

USE_PYTHON= test (or nosetests, there's enough ports with that as well)

devel/py-check-manifest/Makefile
8–9 ↗(On Diff #11024)

Exactly what I thought, looking at that port.

mat edited edge metadata.
This revision is now accepted and ready to land.Dec 10 2015, 3:20 PM

I'll think about/look into support in python.mk. In the meantime, either do-test (or DO_MAKE_TEST/TEST_TARGET) in ports is fine.

This revision was automatically updated to reflect the committed changes.
miwi mentioned this in rP403482: - Update to 0.29.