databases/p5-SQL-Abstract-More: Update to 1.43

[uzsolt]

Summary

Changelog: https://metacpan.org/changes/distribution/SQL-Abstract-More

PR: 276490
Approved by: ...
(Differential Revision: https://reviews.freebsd.org/D)

git commit --author ...

Test Plan

Poudriere testport passed on 13.2, 13.3, 14.0 (amd64), some warning:

Warning: devel/p5-Module-Build was in Perl CORE. Check with `corelist
Module::Build 0.4206` and corelist -a Module::Build if it should be
conditionally added depending on PERL_LEVEL
Notice: You have some Perl modules as dependencies but you do not have
devel/p5-Module-CoreList installed, the perlcore QA check gets better results
when using it, especially with older Perl versions.

Portlint, portfmt, portclippy look fine.

make test passed.

[uzsolt]

Sorry, I forgot the PR link: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=276490

[diizzy]

On my box security/p5-openxpki-i18n fails which is a dependency of security/p5-openxpki (which also depends on this port), until that port is fixed so we can build the other one it's "on hold" status

[uzsolt]

In D44574#1023350, @diizzy wrote:

On my box security/p5-openxpki-i18n fails which is a dependency of security/p5-openxpki (which also depends on this port), until that port is fixed so we can build the other one it's "on hold" status

Can build the port and the "make test" run fine. Could you check please?

[svysh.fbsd_gmail.com]

In D44574#1023350, @diizzy wrote:

On my box security/p5-openxpki-i18n fails which is a dependency of security/p5-openxpki (which also depends on this port), until that port is fixed so we can build the other one it's "on hold" status

Daniel,

Most probably there is a misunderstanding.

1. Consider 3 ports (as it happens, I maintain of all of them), mentioned by diizzy:

port A: security/p5-openxpki
port B: security/p5-openxpki-i18n
port C: databases/p5-SQL-Abstract-More (which is the port being considered in this PR).

If port X depends (directly or indirectly) from port Y, let us designate this dependency with symbolic expressions as: "X -> Y" or "Y <- X".

Then dependencies between 3 mentioned ports are as follows:

B <- A -> C

This symbolic expression is evident from looking at the page:

https://ports.freebsd.org/cgi/ports.cgi?query=xpki&stype=all&sektion=all

That is, our port C (being considered here) is needed to build port A. But ports A and B are irrelevant for building of port C.

2. On my box I can build all of 3 ports just fine:

14.0-RELEASE-p6
portlint 2.22.1
portfmt 1.1.5
pkg 1.21.99.1
poudriere-git-3.4.99.20240424
perl 5.36.3_1
openssl 3.0.12

3. Actually at the moment I am waiting for you to commit this PR with update for port C. It is needed for me to submit a new version of port A with major update.

Hope this helps.
Regards, Sergei Vyshenski

[svysh.fbsd_gmail.com]

Oh, it seems that I am beginning to understand the meaning of Daniel's comment.

Port security/p5-openxpki-i18n (referred to as port B above) fails to build after recent updates to gettext.

This failure happens with or without applying a patch for port databases/p5-SQL-Abstract-More, proposed here.

Let me investigate further.

Thank you so much for the alert.
Regards, Sergei

[uzsolt]

In D44574#1030915, @svysh.fbsd_gmail.com wrote:

Oh, it seems that I am beginning to understand the meaning of Daniel's comment.

Port security/p5-openxpki-i18n (referred to as port B above) fails to build after recent updates to gettext.

This failure happens with or without applying a patch for port databases/p5-SQL-Abstract-More, proposed here.

I can build security/p5-openxpki{,-i18n} with updated p5-SQL-Abstract-More, on 13.2, 13.3 and 14.0 (poudriere).

[svysh.fbsd_gmail.com]

Blinking failure of build for port security/p5-openxpki-i18n goes away altogether, if I add a line:

MAKE_JOBS_UNSAFE= yes

to the Makefile of port security/p5-openxpki-i18n, just under the line:

USE_GITHUB= yes

And again, my tests show, that this blinking problem manifests itself irrespective of applying or not applying the patch (under discussion here) for the port databases/p5-SQL-Abstract-More. I will submit a major stable update of ports security/p5-openxpki{-i18n}, which will address this issue. Hopefully very soon. But IMHO, port databases/p5-SQL-Abstract-More could be updated right away (with the present patch), irrespective of that future major update.

[svysh.fbsd_gmail.com]

Hi,

To simplify things, I have submitted a PR with a simple patch to fix blinking build error in existing version of port security/p5-openxpki-i18n:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279058

Hope this helps.
Regards, Sergei

[diizzy]

Commit https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=279058 first then this one,

Regarding PR 279058:
You don't need to bump PORTREVISION
Remove comment for MAKE_JOBS_UNSAFE, it's it commit msg
"stay with" --> track and remove only at the end --> track stable versions

In general for Makefiles we tend to prefer having comments on a separate line rather than to the right but do as you wish.

Commit msg for PR 279058 (or something similar):

security/p5-openxpki-i18n: Fix build

Add MAKE_JOBS_UNSAFE=yes due to race conditions during build
While at it do some minor adjustments to Makefile

Great work :-)