Differential D43925

pci_host_generic: Properly handle bus_release_resource of IRQ resources
ClosedPublic
Actions

Authored by jhb on Feb 16 2024, 12:03 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Dec 7, 6:49 AM

	Unknown Object (File)
	Sun, Dec 7, 6:27 AM

	Unknown Object (File)
	Mon, Nov 24, 4:31 PM

	Unknown Object (File)
	Wed, Nov 12, 5:56 PM

	Unknown Object (File)
	Nov 6 2025, 7:45 PM

	Unknown Object (File)
	Nov 6 2025, 7:03 AM

	Unknown Object (File)
	Nov 5 2025, 8:36 PM

	Unknown Object (File)
	Nov 5 2025, 9:56 AM

View All 73 Files

Subscribers

Details

Reviewers

Commits

rG2afea415b919: pci_host_generic: Properly handle bus_release_resource of IRQ resources
rGfeefc3c71e33: pci_host_generic: Properly handle bus_release_resource of IRQ resources

Summary

Unlike other bus methods updated to use bus_generic_rman_* in commit
d79b6b8ec267, the bus_release_resource method was using
bus_generic_rman_release_resource for all types other than
PCI_RES_BUS. Instead, bus_generic_rman_* should only be used for
memory and I/O port resources for this driver.

Reported by: cperciva
Fixes: d79b6b8ec267 pci_host_generic: Don't rewrite resource start address for translation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Feb 16 2024, 12:03 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 16 2024, 12:03 AM

jhb requested review of this revision.Feb 16 2024, 12:03 AM

Harbormaster completed remote builds in B56053: Diff 134403.Feb 16 2024, 12:03 AM

Confirmed, this fixes the panic I'm seeing on EC2 arm64 instances.

This revision is now accepted and ready to land.Feb 16 2024, 1:18 AM

Closed by commit rGfeefc3c71e33: pci_host_generic: Properly handle bus_release_resource of IRQ resources (authored by jhb). · Explain WhyFeb 16 2024, 1:56 AM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGfeefc3c71e33: pci_host_generic: Properly handle bus_release_resource of IRQ resources.

jhb added a commit: rG2afea415b919: pci_host_generic: Properly handle bus_release_resource of IRQ resources.Feb 27 2025, 2:22 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

pci/

pci_host_generic.c

16 lines

Diff 134407

sys/dev/pci/pci_host_generic.c

Loading...