security/py-letsencrypt: Update to 0.1.0
ClosedPublic
Actions

Authored by brnrd on Dec 3 2015, 3:33 PM.

Details

Reviewers

cpm
koobs
feld

Commits

rP403057: security/py-letsencrypt: Update to 0.1.0

Summary

Proposed commit log

security/py-letsencrypt: Update to 0.1.0

 - Update py-letsencrypt to 0.1.0
 - Update py-acme to 0.1.0
 - Update pkg-message accordingly

This marks the first non-development release of Letsencrypt.org for the public BETA

ReviewedBy:	koobs (mentor, maintainer), cpm_fbsd.es (maintainer), feld
Approved By:	
MFH:		2015Q4
DifferentialRevision:	https://reviews.freebsd.org/D4360

Test Plan

Poudriere testport py-acme: pass py-letsencrypt: pass
make test
- py-acme Ran 347 tests in 6.084s OK
- py-letsencrypt Ran 417 tests in 11.355s OK
portlint -AC (no change, clean)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

brnrd updated this revision to Diff 10703.Dec 3 2015, 3:33 PM

brnrd retitled this revision from to security/py-letsencrypt: Update to 0.1.0.

brnrd updated this object.

brnrd edited the test plan for this revision. (Show Details)

brnrd added reviewers: koobs, feld.

brnrd updated this object.Dec 3 2015, 3:42 PM

brnrd edited the test plan for this revision. (Show Details)

brnrd edited the test plan for this revision. (Show Details)Dec 3 2015, 3:46 PM

brnrd added a reviewer: cpm.

brnrd updated this object.Dec 3 2015, 3:59 PM

Update pkg-message for security/py-letsencrypt

Reflect that this is now in OPEN BETA

brnrd updated this object.Dec 3 2015, 4:06 PM

brnrd edited the test plan for this revision. (Show Details)

I approve getting this committed as well as the necessary work to MFH to quarterly so 10.1+ pkg users can just "pkg install" and use it

This revision is now accepted and ready to land.Dec 3 2015, 4:34 PM

Please add MFH: 2015Q4 to the commit log as per @feld comment

security/py-letsencrypt/pkg-message
23 ↗	(On Diff #10704)	Did the default behaviour of the client change?

brnrd updated this object.Dec 4 2015, 8:15 AM

brnrd edited edge metadata.

brnrd marked an inline comment as done.Dec 4 2015, 9:58 AM

brnrd added inline comments.

security/py-letsencrypt/pkg-message
23 ↗	(On Diff #10704)	Yes, the behaviour has changed, no need for the --server anymore, just successfully installed a cert using the public beta letsencrypt -a manual auth -d test.example.org --rsa-key-size 4096 --text

LGMT

Removed a bit too much from the pkg-message

This revision now requires review to proceed.Dec 4 2015, 10:00 AM

koobs accepted this revision.Dec 4 2015, 10:07 AM

koobs edited edge metadata.

This revision is now accepted and ready to land.Dec 4 2015, 10:07 AM

cpm accepted this revision.Dec 4 2015, 3:06 PM

cpm edited edge metadata.

Closed by commit rP403057: security/py-letsencrypt: Update to 0.1.0 (authored by brnrd). · Explain WhyDec 5 2015, 11:08 AM

This revision was automatically updated to reflect the committed changes.

koobs reopened this revision.Dec 5 2015, 12:17 PM

This revision is now accepted and ready to land.Dec 5 2015, 12:17 PM

Re-open for MFH discussion.

@feld, can you take this please.

My position is:

I agree and would like quarterly users to have py27-letsencrypt available to them
I understand the QA requirements and complexity getting this MFH'd

@brnrd, please include the portmgr response to the MFH request email they received on HEAD commit, if its suitable for public consumption. If not, you may paraphrase it instead

From portmgr@ via mail

This port is not in the quarterly branch.
Not approved.

I strongly believe that this should be available for anyone. Using the default installation mode including py-virtualenv is not portable to ports for next quarter.

Can this be closed now? It has not made progress and a new quarterly cut is coming in ~4 days.

Committed to HEAD in rP403057

Was pending MFH, but was not approved

feld closed this revision.Dec 27 2015, 2:19 AM