Page MenuHomeFreeBSD
Differential D43464

fusefs: prefer new/delete over malloc/free
ClosedPublic
Actions

Authored by asomers on Jan 15 2024, 11:50 PM.
Tags
None
Referenced Files
F166514502: D43464.id132800.diff
Thu, Aug 13, 9:58 PM
Unknown Object (File)
Tue, Aug 11, 2:31 PM
Unknown Object (File)
Tue, Aug 11, 2:30 PM
Unknown Object (File)
Tue, Aug 11, 2:29 PM
Unknown Object (File)
Sun, Aug 9, 12:29 PM
Unknown Object (File)
Fri, Aug 7, 6:21 PM
Unknown Object (File)
Wed, Aug 5, 7:53 AM
Unknown Object (File)
Jun 15 2026, 7:37 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
Commits
rGc7fc7a4b9c45: fusefs: prefer new/delete over malloc/free
rG8510b8fe2abc: fusefs: prefer new/delete over malloc/free
rG8bae22bbbe65: fusefs: prefer new/delete over malloc/free
Summary

MFC after: 2 weeks

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers created this revision.Jan 15 2024, 11:50 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 15 2024, 11:50 PM
asomers requested review of this revision.Jan 15 2024, 11:50 PM
Harbormaster completed remote builds in B55452: Diff 132800.Jan 15 2024, 11:50 PM
kib added inline comments.Jan 16 2024, 12:36 AM
tests/sys/fs/fusefs/bmap.cc
247

buf = new char[filesize](); ?

251

I think this should be delete[] buf;

asomers added inline comments.Jan 16 2024, 2:53 AM
tests/sys/fs/fusefs/bmap.cc
247

The parenthesis aren't required. Are you saying that you would like them, as a matter of style?

251

good catch.

kib added inline comments.Jan 16 2024, 2:23 PM
tests/sys/fs/fusefs/bmap.cc
247

Parenthesis means to apply default initializer, to replace the memset().

asomers marked an inline comment as done.Jan 17 2024, 9:18 PM
asomers added inline comments.
tests/sys/fs/fusefs/bmap.cc
247

ahh.

asomers updated this revision to Diff 132895.Jan 17 2024, 9:19 PM
asomers marked an inline comment as done.
  • Replaces memsets by default initializers. Delete allocations using
Harbormaster completed remote builds in B55469: Diff 132895.Jan 17 2024, 9:19 PM
kib accepted this revision.Jan 17 2024, 10:26 PM
This revision is now accepted and ready to land.Jan 17 2024, 10:26 PM
Closed by commit rG8bae22bbbe65: fusefs: prefer new/delete over malloc/free (authored by asomers). · Explain WhyJan 17 2024, 10:50 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rG8bae22bbbe65: fusefs: prefer new/delete over malloc/free.
asomers added a commit: rG8510b8fe2abc: fusefs: prefer new/delete over malloc/free.Feb 12 2024, 5:45 PM
asomers added a commit: rGc7fc7a4b9c45: fusefs: prefer new/delete over malloc/free.Jun 13 2024, 7:41 PM

Revision Contents
Changeset List

PathSize
tests/
sys/
fs/
fusefs/
5 lines
22 lines
6 lines
30 lines
14 lines
23 lines
94 lines

Diff 132897

View Options

tests/sys/fs/fusefs/bmap.cc

Loading...
View Options

tests/sys/fs/fusefs/copy_file_range.cc

Loading...
View Options

tests/sys/fs/fusefs/fallocate.cc

Loading...
View Options

tests/sys/fs/fusefs/io.cc

Loading...
View Options

tests/sys/fs/fusefs/read.cc

Loading...
View Options

tests/sys/fs/fusefs/setattr.cc

Loading...
View Options

tests/sys/fs/fusefs/write.cc

Loading...