Page MenuHomeFreeBSD
Differential D43446

Add a regression test for PR 276191.
ClosedPublic
Actions

Authored by asomers on Jan 13 2024, 3:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 26, 12:32 AM
Unknown Object (File)
Fri, Jun 21, 10:39 AM
Unknown Object (File)
Fri, Jun 21, 8:54 AM
Unknown Object (File)
Fri, Jun 21, 7:23 AM
Unknown Object (File)
Fri, Jun 21, 2:04 AM
Unknown Object (File)
Fri, Jun 21, 2:02 AM
Unknown Object (File)
Fri, Jun 21, 1:35 AM
Unknown Object (File)
Apr 28 2024, 7:43 PM
View All 13 Files
Subscribers
imp

Details

Reviewers
kib
Commits
rG62f890cfbc35: Add a regression test for PR 276191.
rGd89317a66ff7: Add a regression test for PR 276191.
rG6b1c534927ad: Add a regression test for PR 276191.
Summary

The bug isn't fusefs-specific, but this is the easiest way to reproduce
it.

MFC with: bdb46c21a3e68d4395d6e0b6a205187e655532b0
MFC after: 1 week
PR: 276191

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asomers created this revision.Jan 13 2024, 3:37 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 13 2024, 3:37 PM
asomers requested review of this revision.Jan 13 2024, 3:37 PM
Harbormaster completed remote builds in B55422: Diff 132732.Jan 13 2024, 3:38 PM
kib accepted this revision.Jan 13 2024, 4:55 PM
kib added inline comments.
tests/sys/fs/fusefs/io.cc
31

This extern decl should be not needed, our system headers are C++ aware.

295

Why malloc+cast, instead of sized new?

511

That said, the assert is already removed.

This revision is now accepted and ready to land.Jan 13 2024, 4:55 PM
asomers added inline comments.Jan 13 2024, 5:01 PM
tests/sys/fs/fusefs/io.cc
31

I can try removing it in a separate commit.

295

Probably because the initial test cases were copied from preexisting C examples. The fusefs test suite currently uses new in few places. Would you like me to change it throughout?

511

Ok, I'll change the comment to past tense.

kib added inline comments.Jan 13 2024, 5:09 PM
tests/sys/fs/fusefs/io.cc
295

IMO it would be better C++. Cast of a malloc() result is ugly even for C programmers.

Closed by commit rG6b1c534927ad: Add a regression test for PR 276191. (authored by asomers). · Explain WhyJan 13 2024, 10:48 PM
This revision was automatically updated to reflect the committed changes.
asomers added a commit: rG6b1c534927ad: Add a regression test for PR 276191..
asomers added a commit: rGd89317a66ff7: Add a regression test for PR 276191..Jan 19 2024, 8:28 PM
asomers added a commit: rG62f890cfbc35: Add a regression test for PR 276191..Jan 20 2024, 2:01 AM

Revision Contents
Changeset List

PathSize
tests/
sys/
fs/
fusefs/
10 lines

Diff 132745

View Options

tests/sys/fs/fusefs/io.cc

Loading...