Restore cleaning of auto-generated kobj files.
ClosedPublic
Actions

Authored by jhb on Dec 1 2015, 6:29 PM.

Details

Reviewers

imp
sbruno

Commits

rS291614: Restore cleaning of auto-generated kobj files after the recent MFILES

Summary

Restore cleaning of auto-generated kobj files after the recent MFILES
changes. Use the list of MFILES found by find to identify the set of
possible auto-generated files and add the intersection of this set and
SRCS to CLEANFILES.

Test Plan

make -V CLEANFILES in sys/modules/oce which has one of the files that the currently commented hack incorrectly removes

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb updated this revision to Diff 10645.Dec 1 2015, 6:29 PM

jhb retitled this revision from to Restore cleaning of auto-generated kobj files..

jhb updated this object.

jhb edited the test plan for this revision. (Show Details)

jhb added a reviewer: imp.

jhb added a subscriber: sbruno.

This should nicely deal with the foo_if.c files that we have in the tree in modules builds that we have today.

This revision is now accepted and ready to land.Dec 1 2015, 6:32 PM

Only pass __MPATH down to the modules to reduce duplication.

This revision now requires review to proceed.Dec 1 2015, 7:46 PM

Yep, this removes the leftover files when I try to build sys/modules/em when I do a make clean.

This revision is now accepted and ready to land.Dec 1 2015, 9:02 PM

jhb added inline comments.Dec 1 2015, 9:18 PM

sys/conf/kern.pre.mk
231 ↗	(On Diff #10645)	Even simpler would be to pass the raw __MPATH down to sub-makes directly. Would then only do the make magic in one place (kmod.mk).