comms/opencbm-kmod: Add error handling for copyin() and copyout() calls

[markj]

Summary

This will be required soon as my intent is to annotate copyin() and
related functions with __result_use_check. Moreover, the lack of error
handling here is a real bug.

I replaced the existing patch file with the one generated by
"make makepatch".

[zirias]

Thanks for this! It seems I goofed here a long time ago when I ported the existing Linux driver to FreeBSD, the original code *does* error-check copy_[from|to]_user().

Would you mind creating an upstream pull request at https://github.com/OpenCBM/OpenCBM as well? The FreeBSD-14 patch was already included there.

comms/opencbm-kmod/files/patch-opencbm.c

36

nitpick, I'd suggest to keep the "condensed" coding style of the original linux driver:

if (rv)
    break;

It doesn't really matter though ....

[markj]

• Bump PORTREVISION
• Remove unneeded braces

[markj]

In D43273#986710, @zirias wrote:

Thanks for this! It seems I goofed here a long time ago when I ported the existing Linux driver to FreeBSD, the original code *does* error-check copy_[from|to]_user().

Would you mind creating an upstream pull request at https://github.com/OpenCBM/OpenCBM as well? The FreeBSD-14 patch was already included there.

Sure, done: https://github.com/OpenCBM/OpenCBM/pull/109

[zirias]

Thanks a lot again, please

[markj]

Thanks for the quick review!