comms/opencbm-kmod: Add error handling for copyin() and copyout() calls
ClosedPublic
Actions

Authored by markj on Jan 2 2024, 5:11 PM.

Details

Reviewers

zirias

Commits

R11:eaa12eb57a42: comms/opencbm-kmod: Add error handling for copyin() and copyout() calls

Summary

This will be required soon as my intent is to annotate copyin() and
related functions with __result_use_check. Moreover, the lack of error
handling here is a real bug.

I replaced the existing patch file with the one generated by
"make makepatch".

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj requested review of this revision.Jan 2 2024, 5:11 PM

markj created this revision.

Harbormaster completed remote builds in B55194: Diff 132121.Jan 2 2024, 5:11 PM

Thanks for this! It seems I goofed here a long time ago when I ported the existing Linux driver to FreeBSD, the original code *does* error-check copy_[from|to]_user().

Would you mind creating an upstream pull request at https://github.com/OpenCBM/OpenCBM as well? The FreeBSD-14 patch was already included there.

comms/opencbm-kmod/files/patch-opencbm.c
37	nitpick, I'd suggest to keep the "condensed" coding style of the original linux driver: if (rv) break; It doesn't really matter though ....

This revision is now accepted and ready to land.Jan 3 2024, 11:34 AM

Bump PORTREVISION
Remove unneeded braces

This revision now requires review to proceed.Jan 3 2024, 3:22 PM

Harbormaster completed remote builds in B55217: Diff 132191.Jan 3 2024, 3:22 PM

In D43273#986710, @zirias wrote:

Thanks for this! It seems I goofed here a long time ago when I ported the existing Linux driver to FreeBSD, the original code *does* error-check copy_[from|to]_user().

Would you mind creating an upstream pull request at https://github.com/OpenCBM/OpenCBM as well? The FreeBSD-14 patch was already included there.

Sure, done: https://github.com/OpenCBM/OpenCBM/pull/109

Thanks a lot again, please
shipit