Page MenuHomeFreeBSD

Simplify MASTER_SITES= GNOME in Makefile
ClosedPublic

Authored by duchateau.olivier_gmail.com on Dec 26 2023, 4:57 PM.
Tags
None
Referenced Files
F132190418: D43183.id132401.diff
Tue, Oct 14, 3:18 PM
F132190416: D43183.id131940.diff
Tue, Oct 14, 3:18 PM
F132190412: D43183.id.diff
Tue, Oct 14, 3:18 PM
F132190407: D43183.id131866.diff
Tue, Oct 14, 3:18 PM
Unknown Object (File)
Sun, Oct 12, 6:57 PM
Unknown Object (File)
Sat, Oct 11, 7:51 PM
Unknown Object (File)
Mon, Oct 6, 2:39 AM
Unknown Object (File)
Mon, Sep 22, 6:15 AM

Details

Summary

Since GNOME changes their numbering, in some Makefile MASTER_SITES= GNOME is more complex. This patch simplify for users.

Moreover, mark x11-toolkits/gnome-pty-helper BROKEN, because it is unfetchable.

Diff Detail

Repository
R11 FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tcberner added inline comments.
Mk/bsd.sites.mk
571

^ it would likely make sense to not use GNOME_VER here, but something internal, like _gnome_ver.

Replace GNOME_VER variable by _gnome_ver

New attempt in order to simplify MASTER_SITES for GNOME ports when DISTVERSION >= 10.

Now gitlab.gnome.org is used as last resort, so it is located at the end of the list.

I found typos in 2 ports devel/tinysparql and x11/ptyxis. Regenerate makesum for these 2 ports because extension changed too.

Moreover I "bumped" PORTREVISION for devel/tinysparql because I have added a patch, otherwise it fails to find textproc/snowballstemmer.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 10 2025, 11:04 AM
This revision was automatically updated to reflect the committed changes.

This breaks ports with non numeric PORTVERSION.

make: "/usr/ports/Mk/bsd.sites.mk" line 586: Comparison with '>=' requires both operands 'g20180112' and '10' to be numeric
make: Fatal errors encountered -- cannot continue
make: "/usr/ports/Mk/bsd.sites.mk" line 586: Comparison with '>=' requires both operands 'g20180112' and '10' to be numeric
make: Fatal errors encountered -- cannot continue
===>>> Launching 'make checksum' for sysutils/bsdfan in background
make: "/usr/ports/Mk/bsd.sites.mk" line 586: Comparison with '>=' requires both operands 'g20180112' and '10' to be numeric
make: Fatal errors encountered -- cannot continue
make: stopped in /usr/ports/sysutils/bsdfan
===>>> Gathering dependency list for sysutils/bsdfan from ports
make: "/usr/ports/Mk/bsd.sites.mk" line 586: Comparison with '>=' requires both operands 'g20180112' and '10' to be numeric
make: Fatal errors encountered -- cannot continue

This change broke at least 4 ports, please run full tests