geom: Report copyout() errors in g_ctl_ioctl_ctl()
ClosedPublic
Actions

Authored by markj on Dec 21 2023, 2:45 AM.

Details

Reviewers

imp
mav

Commits

rGbd8a789e3c28: geom: Report copyout() errors in g_ctl_ioctl_ctl()
rGbd287fa8bcac: geom: Report copyout() errors in g_ctl_ioctl_ctl()
rGbbf221e3e822: geom: Report copyout() errors in g_ctl_ioctl_ctl()

Summary

Despite the name, req->serror is used in some cases to copy non-error
messages to userspace. So, report errors when copying out so long as
they don't clobber an earlier error.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj requested review of this revision.Dec 21 2023, 2:45 AM

markj created this revision.

Harbormaster completed remote builds in B55061: Diff 131630.Dec 21 2023, 2:45 AM

mav accepted this revision.Dec 21 2023, 2:51 PM

This revision is now accepted and ready to land.Dec 21 2023, 2:51 PM

imp accepted this revision.Dec 21 2023, 3:02 PM

Closed by commit rGbbf221e3e822: geom: Report copyout() errors in g_ctl_ioctl_ctl() (authored by markj). · Explain WhyDec 26 2023, 2:10 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGbbf221e3e822: geom: Report copyout() errors in g_ctl_ioctl_ctl().

markj added a commit: rGbd287fa8bcac: geom: Report copyout() errors in g_ctl_ioctl_ctl().Jan 2 2024, 12:39 AM

markj added a commit: rGbd8a789e3c28: geom: Report copyout() errors in g_ctl_ioctl_ctl().Jan 2 2024, 1:17 AM

Revision Contents
Changeset List

Path

Size

sys/

geom/

geom_ctl.c

4 lines

Diff 131859

View Options

geom: Report copyout() errors in g_ctl_ioctl_ctl()ClosedPublicActions