ocs: Check for copyin errors in the ioctl handler
ClosedPublic
Actions

Authored by markj on Dec 19 2023, 3:13 AM.

Details

Reviewers

ram
ken
imp

Commits

rGf5a139a03767: ocs: Check for copyin errors in the ioctl handler
rGd8fe1e4c5a9d: ocs: Check for copyin errors in the ioctl handler
rGa01ff11cb73d: ocs: Check for copyin errors in the ioctl handler

Summary

If copyin() fails, the driver will blindly proceed with whatever had
been in the uninitialized DMA buffer. This is not what we want. Check
for copyin failures.

This is in preparation for annotating copyin() and related functions
with __result_use_check.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj requested review of this revision.Dec 19 2023, 3:13 AM

markj created this revision.

Harbormaster completed remote builds in B55003: Diff 131548.Dec 19 2023, 3:13 AM

Changes look good.

This revision is now accepted and ready to land.Dec 19 2023, 9:07 AM

Closed by commit rGa01ff11cb73d: ocs: Check for copyin errors in the ioctl handler (authored by markj). · Explain WhyDec 26 2023, 2:04 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rGa01ff11cb73d: ocs: Check for copyin errors in the ioctl handler.

markj added a commit: rGd8fe1e4c5a9d: ocs: Check for copyin errors in the ioctl handler.Jan 2 2024, 12:38 AM

markj added a commit: rGf5a139a03767: ocs: Check for copyin errors in the ioctl handler.Jan 2 2024, 1:15 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

ocs_fc/

ocs_ioctl.c

24 lines

Diff 131842

View Options

sys/dev/ocs_fc/ocs_ioctl.c

ocs: Check for copyin errors in the ioctl handlerClosedPublicActions