Page MenuHomeFreeBSD
Differential D42686

Remove __FBSDID from netbsd libc sources
ClosedPublic
Actions

Authored by brooks on Nov 20 2023, 10:02 PM.
Tags
None
Referenced Files
F106172162: D42686.diff
Thu, Dec 26, 2:06 PM
Unknown Object (File)
Wed, Nov 27, 3:20 AM
Unknown Object (File)
Wed, Nov 27, 3:20 AM
Unknown Object (File)
Wed, Nov 27, 3:20 AM
Unknown Object (File)
Wed, Nov 27, 3:06 AM
Unknown Object (File)
Nov 1 2024, 1:54 PM
Unknown Object (File)
Oct 31 2024, 2:16 PM
Unknown Object (File)
Oct 27 2024, 2:04 PM
View All 42 Files
Subscribers
None

Details

Reviewers
imp
Commits
rG52b970f98df5: Remove __FBSDID from netbsd libc sources
rGea2be8ed2835: Remove __FBSDID from netbsd libc sources
Summary

I added them per then-current practice when I imported them, but now
they are just gratuious local diffs.

In vis.c, relocate the compat definition of _DIAGASSERT() to somewhere
more normal.

Diff Detail

Repository
rG FreeBSD src repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 54526
Build 51415: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Nov 20 2023, 10:02 PM
brooks created this revision.
Harbormaster completed remote builds in B54526: Diff 130352.Nov 20 2023, 10:02 PM
brooks added a comment.Nov 20 2023, 10:10 PM

I've updated this locally to make the _DIAGASSERT change first as a separate commit.

imp accepted this revision.Nov 20 2023, 10:31 PM

Looks good. 2 commits or 1 doesn't matter, but 2 is a bit better.

This revision is now accepted and ready to land.Nov 20 2023, 10:31 PM
Closed by commit rGea2be8ed2835: Remove __FBSDID from netbsd libc sources (authored by brooks). · Explain WhyNov 21 2023, 12:21 AM
This revision was automatically updated to reflect the committed changes.
brooks mentioned this in rGdb94e7c3f9a2: vis: relocate _DIAGASSERT() define.
brooks added a commit: rGea2be8ed2835: Remove __FBSDID from netbsd libc sources.
brooks mentioned this in rG0f6bc5ca95b7: vis: relocate _DIAGASSERT() define.Dec 13 2023, 11:23 PM
brooks added a commit: rG52b970f98df5: Remove __FBSDID from netbsd libc sources.

Revision Contents
Changeset List

PathSize
contrib/
libc-pwcache/
1 line
libc-vis/
1 line
6 lines

Diff 130352

View Options

contrib/libc-pwcache/pwcache.c

Loading...
View Options

contrib/libc-vis/unvis.c

Loading...
View Options

contrib/libc-vis/vis.c

Loading...